Repository navigation
feat: Add mutating, validating webhooks for Jobs to allow reconciliation - #1360
Open
Arvind Thirumurugan (Arvindthiru) wants to merge 2 commits into
Open
Arvind Thirumurugan (Arvindthiru) wants to merge 2 commits into
Arvind Thirumurugan (Arvindthiru) wants to merge 2 commits into
Conversation
…llow job controller to create pods based on label Signed-off-by: Arvind Thirumurugan <arvindth@microsoft.com>
Britania Rodriguez Reyes (britaniar)
previously approved these changes
Oct 8, 2026
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Adds mutating and validating webhooks for batch/v1 Jobs, matching the existing Deployment behavior.
Adds fleet.azure.com/reconcile=managed to Job and pod-template labels for aksService requests.
Prevents unauthorized users from setting the managed label.
Registers Job mutating and validating admission rules.
Updates the Admission Policy Manager to allow job-controller to create Pods carrying the managed reconcile label.
Adds webhook and admission-policy test coverage.
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer