Skip to content

Support tags on entity-started orchestrations #1412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wangbill (YunchuWang) wants to merge 1 commit into
base: main
Choose a base branch
from
+420 −4
Open

Support tags on entity-started orchestrations #1412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/DurableTask.Core/Entities/OperationFormat/StartNewOrchestrationOperationAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,15 @@ public class StartNewOrchestrationOperationAction : OperationAction
/// </summary>
public string? Input { get; set; }

/// <summary>
/// Gets or sets the tags of the sub-orchestration.
/// </summary>
/// <remarks>
/// These tags override tags inherited from the entity. The runtime always sets the
/// <see cref="OrchestrationTags.FireAndForget"/> tag.
/// </remarks>
public IDictionary<string, string>? Tags { get; set; }

/// <summary>
/// Gets or sets when to start the orchestration, or null if the orchestration should be started immediately.
/// </summary>
Expand Down
4 changes: 3 additions & 1 deletion src/DurableTask.Core/TaskEntityDispatcher.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -912,7 +912,9 @@ internal void ProcessSendStartMessage(WorkItemEffects effects, OrchestrationRunt
{
Tags = OrchestrationTags.MergeTags(
newTags: new Dictionary<string, string>() { { OrchestrationTags.FireAndForget, "" } },
existingTags: runtimeState.Tags),
existingTags: OrchestrationTags.MergeTags(
newTags: action.Tags,
existingTags: runtimeState.Tags)),
OrchestrationInstance = destination,
ScheduledStartTime = action.ScheduledStartTime,
ParentInstance = new ParentInstance
Expand Down
Loading
Loading