Suppress false-positive CodeQL warning on TraceContextBase#1350
Open
Suppress false-positive CodeQL warning on TraceContextBase#1350
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an inline justification comment intended to suppress a CodeQL false-positive on TraceContextBase’s Newtonsoft.Json TypeNameHandling configuration, relying on TraceContextBase.Restore(...) type validation to explain why the deserialization is safe in this context.
Changes:
- Added a CodeQL suppression/justification comment next to
TypeNameHandling = TypeNameHandling.ObjectsinTraceContextBase’s serializer settings.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+44
to
46
| // CodeQL [SM02211] Internal-only payload; Restore validates root $type is a TraceContextBase subclass. | ||
| TypeNameHandling = TypeNameHandling.Objects, | ||
| PreserveReferencesHandling = PreserveReferencesHandling.Objects, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves https://msazure.visualstudio.com/Antares/_workitems/edit/37181650