Skip to content

[AutoPR azure-mgmt-resource-features]-generated-from-SDK Generation - Python-6890359 - #49227

Merged
ChenxiJiang333 merged 3 commits into
mainfrom
sdkauto/azure-mgmt-resource-features-6889931
Sep 28, 2026
Merged

ChenxiJiang333 merged 3 commits into
mainfrom
sdkauto/azure-mgmt-resource-features-6889931

Conversation

@azure-sdk-automation

@azure-sdk-automation azure-sdk-automation Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Configurations: 'specification/resources/resource-manager/Microsoft.Features/features/readme.md', API Version: 2021-07-01, SDK Release Type: stable, and CommitSHA: 'c7569077719927adf8835d79ef8d0763dd3d492d' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6890359 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.

…eatures/features/readme.md', API Version: 2021-07-01, SDK Release Type: stable, and CommitSHA: 'e0ff5b8f285f1da87d2c0dedac03c947b6fb7964' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6889931 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
9 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@ChenxiJiang333
ChenxiJiang333 marked this pull request as ready for review September 28, 2026 06:57
Copilot AI balanced review requested due to automatic review settings September 28, 2026 06:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The documented Python 3.10 minimum conflicts with package metadata that still permits Python 3.9.

Review effort: Balanced
Findings: 1 Medium severity

Open (1)
What changed in this PR

Promotes azure-mgmt-resource-features from beta to GA version 1.0.0.

Changes:

  • Marks the package stable and updates its version/changelog.
  • Updates README requirements and terminology.
  • Adds APIView artifacts and generation metadata.
File Description
README.md Updates Python support and authentication terminology.
pyproject.toml Marks the package production/stable.
CHANGELOG.md Adds the 1.0.0 GA release.
_version.py Sets version 1.0.0.
api.metadata.yml Adds APIView metadata.
api.md Adds the public API snapshot.
_metadata.json Updates generation provenance and tooling.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread sdk/resources/azure-mgmt-resource-features/README.md
Comment thread sdk/resources/azure-mgmt-resource-features/pyproject.toml Outdated
Comment thread sdk/resources/azure-mgmt-resource-features/pyproject.toml Outdated
Copilot AI review requested due to automatic review settings September 28, 2026 07:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The package still permits installation on unsupported Python 3.9 despite declaring Python 3.10 as the minimum.

Review effort: Balanced
Findings: 1 Medium severity

Open (1)
Resolved since last review (1)

Comment thread sdk/resources/azure-mgmt-resource-features/pyproject.toml
Copilot AI review requested due to automatic review settings September 28, 2026 07:59
@azure-sdk-automation azure-sdk-automation Bot changed the title [AutoPR azure-mgmt-resource-features]-generated-from-SDK Generation - Python-6889931 [AutoPR azure-mgmt-resource-features]-generated-from-SDK Generation - Python-6890181 Sep 28, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The changelog still contains a generator placeholder, and the documented Python minimum conflicts with package metadata.

Review effort: Balanced
Findings: 1 Medium severity · 1 Low severity

Open (2)

Comment thread sdk/resources/azure-mgmt-resource-features/CHANGELOG.md Outdated
Copilot AI review requested due to automatic review settings September 28, 2026 08:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The changelog placeholder and contradictory Python 3.9 classifier must be corrected before release.

Review effort: Balanced
Findings: 1 Low severity

Open (1)
Resolved since last review (2)

Comment thread sdk/resources/azure-mgmt-resource-features/pyproject.toml
Comment thread sdk/resources/azure-mgmt-resource-features/pyproject.toml Outdated
Copilot AI review requested due to automatic review settings September 28, 2026 08:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

The release changelog still contains a generator placeholder that would be published to users.

Review effort: Balanced
Findings: None

Resolved since last review (1)

Copilot AI review requested due to automatic review settings September 28, 2026 08:31
@azure-sdk-automation azure-sdk-automation Bot changed the title [AutoPR azure-mgmt-resource-features]-generated-from-SDK Generation - Python-6890181 [AutoPR azure-mgmt-resource-features]-generated-from-SDK Generation - Python-6890359 Sep 28, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

The changelog contains a generator placeholder, and the documented Python requirement conflicts with package metadata.

Review effort: Balanced
Findings: None

Copilot AI review requested due to automatic review settings September 28, 2026 08:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The recorded source commit conflicts with the commit identified in the PR description.

Review effort: Balanced
Findings: 1 Medium severity

Open (1)

Comment thread sdk/resources/azure-mgmt-resource-features/_metadata.json
@github-actions

Copy link
Copy Markdown
Contributor
[Pilot] PR Pipeline Failure Analysis

What failed

Azure Pipeline build 6890455 failed on the python - pullrequest check (job: Build Analyze). The changelog validation step for azure-mgmt-resource-features failed because the ## 1.0.0 (2026-09-28) entry in sdk/resources/azure-mgmt-resource-features/CHANGELOG.md does not contain a recognized section header.

Root cause: The new changelog entry uses ## Other Changes (an H2 heading), but the validator expects one of the recommended section headers as an H3 (### Features Added, ### Breaking Changes, ### Bugs Fixed, ### Other Changes) — matching the format already used by the existing 1.0.0b1 entry lower in the same file (### Other Changes). Because the heading level doesn't match, the validator treats the entry as missing a recognized section.

Relevant pipeline output
Verifying changelog for azure-mgmt-resource-features
Found the following change log entry for version '1.0.0' in [sdk/resources/azure-mgmt-resource-features/CHANGELOG.md].
-----
## 1.0.0 (2026-09-28)

## Other Changes

  - First GA

-----
[debug]Verifying as a release build because the changelog entry has a valid date.
##[error]The changelog entry did not contain any of the recommended sections (Features Added, Breaking Changes, Bugs Fixed, Other Changes), please add at least one. See https://aka.ms/azsdk/guideline/changelogs for more info.
##[error]PowerShell exited with code '1'.

Recommended next steps

  • In sdk/resources/azure-mgmt-resource-features/CHANGELOG.md, change the ## Other Changes heading under the 1.0.0 (2026-09-28) entry to ### Other Changes (H3), matching the style used elsewhere in the file.
  • Verify locally by re-running the changelog validation step, or by comparing the entry format against https://aka.ms/azsdk/guideline/changelogs.

Automated fix: Requested

Generated by Pipeline Analysis Next Steps · copilot · sonnet50 · 80.7 AIC · ⌖ 6 AIC · ⊞ 8.8K · ◷

Copilot AI review requested due to automatic review settings September 28, 2026 09:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

The generation metadata conflicts with the declared source commit and no longer pins the advertised API-version tag.

Review effort: Balanced
Findings: None

Resolved since last review (1)
Previously missed (1)

In code that hasn't changed since last review

Medium severity Generation command omits the declared API version tag

sdk/​resources/​azure-mgmt-resource-features/​_metadata.json:9

This command no longer pins --tag=package-features-2021-07, although the PR declares API version 2021-07-01 and the previous reproducible command explicitly selected that tag. Re-running the recorded command can therefore follow whatever tag the spec readme defaults to rather than the advertised API configuration. Please generate with the explicit tag and preserve it in the metadata.

@ChenxiJiang333
ChenxiJiang333 enabled auto-merge (squash) September 28, 2026 09:35
@ChenxiJiang333
ChenxiJiang333 merged commit 98a83a8 into main Sep 28, 2026
21 checks passed
@ChenxiJiang333
ChenxiJiang333 deleted the sdkauto/azure-mgmt-resource-features-6889931 branch September 28, 2026 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants