Skip to content

[AutoPR azure-mgmt-resource-locks]-generated-from-SDK Generation - Python-6890356 - #49226

Merged
ChenxiJiang333 merged 2 commits into
mainfrom
sdkauto/azure-mgmt-resource-locks-6889935
Sep 28, 2026
Merged

ChenxiJiang333 merged 2 commits into
mainfrom
sdkauto/azure-mgmt-resource-locks-6889935

Conversation

@azure-sdk-automation

@azure-sdk-automation azure-sdk-automation Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Configurations: 'specification/resources/resource-manager/Microsoft.Authorization/locks/readme.md', API Version: 2020-05-01, SDK Release Type: stable, and CommitSHA: 'c7569077719927adf8835d79ef8d0763dd3d492d' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6890356 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.

…uthorization/locks/readme.md', API Version: 2020-05-01, SDK Release Type: stable, and CommitSHA: 'e0ff5b8f285f1da87d2c0dedac03c947b6fb7964' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6889935 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
9 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@ChenxiJiang333
ChenxiJiang333 marked this pull request as ready for review September 28, 2026 06:57
Copilot AI balanced review requested due to automatic review settings September 28, 2026 07:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The package metadata still permits Python 3.9 despite the new documented and classified Python 3.10 minimum.

Review effort: Balanced
Findings: 1 Medium severity

Open (1)
What changed in this PR

Promotes azure-mgmt-resource-locks 1.0.0 to stable using API version 2020-05-01.

Changes:

  • Adds system metadata and structured error models.
  • Updates generated clients, tests, and samples to API 2020-05-01.
  • Updates release, runtime, and APIView metadata.
File Description
README.md Updates Python and authentication guidance.
pyproject.toml Marks package stable and updates classifiers.
generated_tests/​test_management_lock_management_locks_operations.py Refreshes generated synchronous tests.
generated_tests/​test_management_lock_management_locks_operations_async.py Refreshes generated asynchronous tests.
generated_tests/​test_management_lock_authorization_operations_operations.py Updates generated API version.
generated_tests/​test_management_lock_authorization_operations_operations_async.py Updates generated async API version.
generated_samples/​management_locks_list_at_subscription_level.py Updates example provenance.
generated_samples/​management_locks_list_at_scope.py Updates example provenance.
generated_samples/​management_locks_list_at_resource_level.py Updates example provenance.
generated_samples/​management_locks_list_at_resource_group_level.py Updates example provenance.
generated_samples/​management_locks_get_at_subscription_level.py Updates example provenance.
generated_samples/​management_locks_get_at_scope.py Updates example provenance.
generated_samples/​management_locks_get_at_resource_level.py Updates example provenance.
generated_samples/​management_locks_get_at_resource_group_level.py Updates example provenance.
generated_samples/​management_locks_delete_at_subscription_level.py Updates example provenance.
generated_samples/​management_locks_delete_at_scope.py Updates example provenance.
generated_samples/​management_locks_delete_at_resource_level.py Updates example provenance.
generated_samples/​management_locks_delete_at_resource_group_level.py Updates example provenance.
generated_samples/​management_locks_create_or_update_at_subscription_level.py Updates example provenance.
generated_samples/​management_locks_create_or_update_at_scope.py Updates example provenance.
generated_samples/​management_locks_create_or_update_at_resource_level.py Updates example provenance.
generated_samples/​management_locks_create_or_update_at_resource_group_level.py Updates example provenance.
generated_samples/​list_provider_operations.py Updates example provenance.
CHANGELOG.md Documents stable 1.0.0 features.
operations/​_operations.py Updates generated synchronous operations.
models/​_models_py3.py Adds system-data and error models.
models/​_management_lock_client_enums.py Adds CreatedByType.
models/​__init__.py Exports new models and enum.
aio/​operations/​_operations.py Adds generated async error deserialization.
aio/​_management_lock_client.py Updates async client documentation.
aio/​_configuration.py Updates async default API version.
_version.py Promotes version to 1.0.0.
_management_lock_client.py Updates synchronous client documentation.
_configuration.py Updates synchronous default API version.
apiview-properties.json Registers new API definitions.
api.metadata.yml Adds API extraction metadata.
api.md Adds generated API surface documentation.
_metadata.json Records updated generation inputs.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread sdk/resources/azure-mgmt-resource-locks/pyproject.toml
Copilot AI review requested due to automatic review settings September 28, 2026 07:57
@azure-sdk-automation azure-sdk-automation Bot changed the title [AutoPR azure-mgmt-resource-locks]-generated-from-SDK Generation - Python-6889935 [AutoPR azure-mgmt-resource-locks]-generated-from-SDK Generation - Python-6890165 Sep 28, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The changelog is unfinished, API documentation is stale, and Python-version metadata conflicts with the README.

Review effort: Balanced
Findings: 2 Medium severity · 2 Low severity

Open (4)

Comment thread sdk/resources/azure-mgmt-resource-locks/README.md
Comment thread sdk/resources/azure-mgmt-resource-locks/CHANGELOG.md Outdated
Comment thread sdk/resources/azure-mgmt-resource-locks/api.md
Copilot AI review requested due to automatic review settings September 28, 2026 08:02

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

The Python requirement metadata conflicts with the README, and the API snapshot omits newly added public models.

Review effort: Balanced
Findings: 1 Low severity

Open (1)
Resolved since last review (3)

Copilot AI review requested due to automatic review settings September 28, 2026 08:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The API review artifacts are stale and the package metadata still advertises unsupported Python 3.9.

Review effort: Balanced
Findings: 2 Low severity

Open (2)
Previously missed (1)

In code that hasn't changed since last review

Low severity Regenerate stale api.md and update its SHA-256 metadata

sdk/​resources/​azure-mgmt-resource-locks/​api.metadata.yml:1

The recorded SHA-256 does not match the checked-in api.md (the file hashes to 73a24010f1ef3fa263097cf81c8e5f57d57a8d7996255507d757782e1b82f2d0). The markdown is also stale: it omits the newly exported error/SystemData models, CreatedByType, and ManagementLockObject.system_data. Regenerate api.md and this metadata together from the current 1.0.0 package so API review evaluates the actual surface.

Comment thread sdk/resources/azure-mgmt-resource-locks/pyproject.toml
Copilot AI review requested due to automatic review settings September 28, 2026 08:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

The generated API snapshot omits the newly introduced public models, enum, and system_data property.

Review effort: Balanced
Findings: None

Resolved since last review (2)

Copilot AI review requested due to automatic review settings September 28, 2026 08:32
@azure-sdk-automation azure-sdk-automation Bot changed the title [AutoPR azure-mgmt-resource-locks]-generated-from-SDK Generation - Python-6890165 [AutoPR azure-mgmt-resource-locks]-generated-from-SDK Generation - Python-6890356 Sep 28, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

The documented Python 3.10 minimum conflicts with package metadata that still permits Python 3.9.

Review effort: Balanced
Findings: None

Copilot AI review requested due to automatic review settings September 28, 2026 08:43
@ChenxiJiang333
ChenxiJiang333 force-pushed the sdkauto/azure-mgmt-resource-locks-6889935 branch from b167c5d to a9147d1 Compare September 28, 2026 08:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The recorded specification commit conflicts with the commit identified in the PR description.

Review effort: Balanced
Findings: 1 Medium severity

Open (1)

Comment thread sdk/resources/azure-mgmt-resource-locks/_metadata.json
@ChenxiJiang333
ChenxiJiang333 merged commit 2d9eddf into main Sep 28, 2026
20 checks passed
@ChenxiJiang333
ChenxiJiang333 deleted the sdkauto/azure-mgmt-resource-locks-6889935 branch September 28, 2026 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants