Skip to content

[AutoPR azure-mgmt-workloadorchestration]-generated-from-SDK Generation - Python-6839253 - #49024

Open
azure-sdk-automation[bot] wants to merge 1 commit into
mainfrom
sdkauto/azure-mgmt-workloadorchestration-6839253
Open

azure-sdk-automation[bot] wants to merge 1 commit into
mainfrom
sdkauto/azure-mgmt-workloadorchestration-6839253

Conversation

@azure-sdk-automation

Copy link
Copy Markdown
Contributor

Configurations: 'specification/edge/resource-manager/Microsoft.Edge/configurationmanager/tspconfig.yaml', and CommitSHA: '87095c76a9f446a727997d12597e59c57a1bb62a' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6839253 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://azsdk-releaseplan-dashboard-hveph5aqhhcfhtgu.westus-01.azurewebsites.net/?releaseplan=36547 Submitted by: Rosa.George@microsoft.com

Copilot AI balanced review requested due to automatic review settings September 15, 2026 17:36
@azure-sdk-automation azure-sdk-automation Bot added the auto-release When merged to main, release pipelines for this PR's changed packages trigger automatically. label Sep 15, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
9 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The regeneration changes a broad preview management API surface and many generated artifacts, warranting final human validation.

Pull request overview

Regenerates the Workload Orchestration management SDK from the 2026-05-01-preview TypeSpec API.

Changes:

  • Adds new operation groups, tests, and samples for the preview API.
  • Updates package metadata, Python support, and version to 1.0.0b2.
  • Migrates packaging configuration into the current project format.
File summaries

All paths are relative to sdk/workloadorchestration/azure-mgmt-workloadorchestration/.

File Description
tsp-location.yaml Updates the TypeSpec source and commit.
sdk_packaging.toml Removes superseded packaging configuration.
README.md Updates Python support and authentication terminology.
MANIFEST.in Refreshes source-distribution contents.
generated_tests/test_workload_orchestration_mgmt_solutions_operations.py Regenerates solution tests.
generated_tests/test_workload_orchestration_mgmt_solutions_operations_async.py Regenerates async solution tests.
generated_tests/test_workload_orchestration_mgmt_solution_templates_operations.py Regenerates solution-template tests.
generated_tests/test_workload_orchestration_mgmt_solution_templates_operations_async.py Regenerates async solution-template tests.
generated_tests/test_workload_orchestration_mgmt_solution_schemas_operations.py Adds solution-schema tests.
generated_tests/test_workload_orchestration_mgmt_solution_schemas_operations_async.py Adds async solution-schema tests.
generated_tests/test_workload_orchestration_mgmt_solution_metadatas_operations.py Adds solution-metadata tests.
generated_tests/test_workload_orchestration_mgmt_solution_metadatas_operations_async.py Adds async solution-metadata tests.
generated_tests/test_workload_orchestration_mgmt_solution_metadata_versions_operations.py Adds metadata-version tests.
generated_tests/test_workload_orchestration_mgmt_solution_metadata_versions_operations_async.py Adds async metadata-version tests.
generated_tests/test_workload_orchestration_mgmt_schemas_operations.py Regenerates schema tests.
generated_tests/test_workload_orchestration_mgmt_schemas_operations_async.py Regenerates async schema tests.
generated_tests/test_workload_orchestration_mgmt_hierarchy_configuration_metadatas_operations.py Adds hierarchy-metadata tests.
generated_tests/test_workload_orchestration_mgmt_hierarchy_configuration_metadatas_operations_async.py Adds async hierarchy-metadata tests.
generated_tests/test_workload_orchestration_mgmt_hierarchy_configuration_metadata_versions_operations.py Adds hierarchy metadata-version tests.
generated_tests/test_workload_orchestration_mgmt_hierarchy_configuration_metadata_versions_operations_async.py Adds async hierarchy metadata-version tests.
generated_tests/test_workload_orchestration_mgmt_dynamic_schemas_operations.py Regenerates dynamic-schema tests.
generated_tests/test_workload_orchestration_mgmt_dynamic_schemas_operations_async.py Regenerates async dynamic-schema tests.
generated_tests/test_workload_orchestration_mgmt_dynamic_schema_versions_operations.py Updates dynamic-schema version parameters.
generated_tests/test_workload_orchestration_mgmt_dynamic_schema_versions_operations_async.py Updates async dynamic-schema version parameters.
generated_tests/test_workload_orchestration_mgmt_diagnostics_operations.py Regenerates diagnostic tests.
generated_tests/test_workload_orchestration_mgmt_diagnostics_operations_async.py Regenerates async diagnostic tests.
generated_tests/test_workload_orchestration_mgmt_contexts_operations.py Regenerates context tests.
generated_tests/test_workload_orchestration_mgmt_contexts_operations_async.py Regenerates async context tests.
generated_tests/test_workload_orchestration_mgmt_config_template_schemas_operations.py Adds config-template schema tests.
generated_tests/test_workload_orchestration_mgmt_config_template_schemas_operations_async.py Adds async config-template schema tests.
generated_samples/ Regenerates preview-API samples and adds samples for new operation groups.
azure/mgmt/workloadorchestration/operations/_patch.py Uses built-in generic annotations.
azure/mgmt/workloadorchestration/operations/__init__.py Exports new operation groups.
azure/mgmt/workloadorchestration/models/_patch.py Uses built-in generic annotations.
azure/mgmt/workloadorchestration/aio/operations/_patch.py Uses built-in generic annotations.
azure/mgmt/workloadorchestration/aio/_patch.py Uses built-in generic annotations.
azure/mgmt/workloadorchestration/_version.py Bumps the package to 1.0.0b2.
azure/mgmt/workloadorchestration/_patch.py Uses built-in generic annotations.
azure/mgmt/__init__.py Adds a namespace-package type suppression.
azure/__init__.py Adds a namespace-package type suppression.
api.metadata.yml Records generated API metadata.
_metadata.json Records the new API version and generator versions.
Review details
  • Files reviewed: 234/239 changed files
  • Comments generated: 0
  • Review effort level: Balanced

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

@ChenxiJiang333 ChenxiJiang333 added the mgmt-review-needed PR for Mgmt SDK is ready to review label Sep 17, 2026
@github-actions

This comment has been minimized.

@ChenxiJiang333 ChenxiJiang333 added mgmt-review-needed PR for Mgmt SDK is ready to review and removed mgmt-review-needed PR for Mgmt SDK is ready to review labels Sep 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Management SDK PR review

Findings: None.

Unverified checks

Unverified checks: None.

Breaking-change attribution

Package: sdk/workloadorchestration/azure-mgmt-workloadorchestration | Release: 1.0.0b2 (2026-09-15)

Changelog entry Cause Evidence and explanation Confidence
Method ConfigTemplatesOperations.update changed type of its parameter properties from ConfigTemplate to ConfigTemplateUpdate (CHANGELOG.md#L106) TypeSpec/API Latest ConfigTemplate.tsp defines model ConfigTemplateUpdate { ...ArmTagsProperty; properties?: ConfigTemplateUpdateProperties; } and update is ArmCustomPatchSync<ConfigTemplate, ConfigTemplateUpdate>. Merge-base ConfigTemplate.tsp instead had update is ArmResourcePatchSync directly against ConfigTemplateProperties, with no dedicated update model. Precise line anchors could not be verified with the tools available in this sandbox; links point to the full file at the correct revision. High — direct model/operation definition change in TypeSpec source
Method ContextsOperations.begin_update changed type of its parameter properties from Context to ContextUpdate (CHANGELOG.md#L107) TypeSpec/API Latest Context.tsp defines model ContextUpdate { ...ArmTagsProperty; properties?: ContextUpdateProperties; } and update is ArmCustomPatchAsync<Context, ContextUpdate>. Precise line anchors could not be verified; link points to the full file at the correct revision. High — direct model/operation definition change in TypeSpec source
Method DiagnosticsOperations.begin_update changed type of its parameter properties from Diagnostic to DiagnosticUpdate (CHANGELOG.md#L108) TypeSpec/API Latest Diagnostics.tsp defines model DiagnosticUpdate { properties?: DiagnosticUpdateProperties; tags?: Record<string>; } and update is ArmCustomPatchAsync<Diagnostic, PatchModel = DiagnosticUpdate>. Precise line anchors could not be verified; link points to the full file at the correct revision. High — direct model/operation definition change in TypeSpec source
Method SchemasOperations.update changed type of its parameter properties from Schema to SchemaUpdate (CHANGELOG.md#L117) TypeSpec/API Latest Schema.tsp defines model SchemaUpdate { properties?: SchemaUpdateProperties; tags?: Record<string>; } and update is ArmCustomPatchSync<Schema, PatchModel = SchemaUpdate>. Precise line anchors could not be verified; link points to the full file at the correct revision. High — direct model/operation definition change in TypeSpec source
Method SolutionTemplatesOperations.update changed type of its parameter properties from SolutionTemplate to SolutionTemplateUpdate (CHANGELOG.md#L118) TypeSpec/API Latest SolutionTemplate.tsp defines model SolutionTemplateUpdate { ...ArmTagsProperty; properties?: SolutionTemplateUpdateProperties; } and update is ArmCustomPatchSync<SolutionTemplate, SolutionTemplateUpdate>. Precise line anchors could not be verified; link points to the full file at the correct revision. High — direct model/operation definition change in TypeSpec source
Method SolutionsOperations.begin_update changed type of its parameter properties from Solution to SolutionUpdate (CHANGELOG.md#L119) TypeSpec/API Latest Solution.tsp defines model SolutionUpdate { properties?: SolutionUpdateProperties; } and update is ArmCustomPatchAsync<Solution, PatchModel = SolutionUpdate>. Precise line anchors could not be verified; link points to the full file at the correct revision. High — direct model/operation definition change in TypeSpec source
Method TargetsOperations.begin_update changed type of its parameter properties from Target to TargetUpdate (CHANGELOG.md#L120) TypeSpec/API Latest Target.tsp defines model TargetUpdate { ...ArmTagsProperty; properties?: TargetUpdateProperties; } and update is ArmCustomPatchAsync<Target, TargetUpdate>, replacing a merge-base operation that patched the full Target/TargetProperties model directly. Precise line anchors could not be verified; link points to the full file at the correct revision. High — direct model/operation definition change in TypeSpec source
Method DynamicSchemaVersionsOperations.begin_create_or_update inserted a positional_or_keyword parameter dynamic_schema_version_name; deleted or renamed schema_version_name (CHANGELOG.md#L109-L110) TypeSpec/API Latest DynamicSchemaVersion.tsp defines model DynamicSchemaVersion is ProxyResource<SchemaVersionProperties> { ...ResourceNameParameter<DynamicSchemaVersion, NamePattern="^(v2-)?[0-9]+\.[0-9]+\.[0-9]+$">; ...EntityTagProperty; }, giving the resource its own explicit name parameter. Merge-base DynamicSchemaVersion.tsp instead had model DynamicSchemaVersion is SchemaVersion;, inheriting the shared SchemaVersion name parameter (generated as schema_version_name), which explains the rename to dynamic_schema_version_name. Precise line anchors could not be verified; links point to the full files at the correct revisions. High — direct model definition change in TypeSpec source
Method DynamicSchemaVersionsOperations.begin_delete inserted dynamic_schema_version_name, deleted schema_version_name (CHANGELOG.md#L111-L112) TypeSpec/API Same DynamicSchemaVersion resource name-parameter change described in the row above. High — direct model definition change in TypeSpec source
Method DynamicSchemaVersionsOperations.get inserted dynamic_schema_version_name, deleted schema_version_name (CHANGELOG.md#L113-L114) TypeSpec/API Same DynamicSchemaVersion resource name-parameter change described above. High — direct model definition change in TypeSpec source
Method DynamicSchemaVersionsOperations.update inserted dynamic_schema_version_name, deleted schema_version_name (CHANGELOG.md#L115-L116) TypeSpec/API Same DynamicSchemaVersion resource name-parameter change described above. High — direct model definition change in TypeSpec source
Method DynamicSchemaVersionsOperations.update/begin_delete/get/begin_create_or_update re-ordered parameters to place dynamic_schema_version_name in sequence (CHANGELOG.md#L121-L124) TypeSpec/API Direct consequence of the same DynamicSchemaVersion resource name-parameter definition change — the new explicit name parameter is generated in a different position than the inherited one used at the merge base. High — direct model definition change in TypeSpec source

Review summary

Reviewed sdk/workloadorchestration/azure-mgmt-workloadorchestration (the only affected package). Checks completed: version consistency (_version.py = 1.0.0b2, matches CHANGELOG.md latest release), preview API version vs. beta SDK version (_metadata.json apiVersion 2026-05-01-preview paired with beta 1.0.0b2), API-version drift (unchanged: 2026-05-01-preview at both first and latest revision), changelog date sanity (2026-09-15, not more than 3 weeks in the future), pyproject.toml stability flags (is_stable = false with Development Status :: 4 - Beta, consistent with the beta version string), client __init__ signature order (credential, subscription_id, base_url in _client.py), and client name consistency (WorkloadOrchestrationMgmtClient matches across _client.py, README.md, and pyproject.toml title). All 20 introduced Breaking Changes entries in the 1.0.0b2 release were traced to direct TypeSpec model/operation definition changes in Azure/azure-rest-api-specs between merge base 802f22a2 and latest 87095c76 — primarily the introduction of dedicated *Update request models (ConfigTemplateUpdate, ContextUpdate, DiagnosticUpdate, SchemaUpdate, SolutionTemplateUpdate, SolutionUpdate, TargetUpdate) and an explicit name parameter added to the DynamicSchemaVersion resource. No rule violations found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-release When merged to main, release pipelines for this PR's changed packages trigger automatically. mgmt-review-needed PR for Mgmt SDK is ready to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants