Skip to content

[AutoPR azure-mgmt-containerservicenodecustomization]-generated-from-SDK Generation - Python-6837270 - #49016

Closed
azure-sdk-automation[bot] wants to merge 1 commit into
mainfrom
sdkauto/azure-mgmt-containerservicenodecustomization-6837270
Closed

azure-sdk-automation[bot] wants to merge 1 commit into
mainfrom
sdkauto/azure-mgmt-containerservicenodecustomization-6837270

Conversation

@azure-sdk-automation

Copy link
Copy Markdown
Contributor

Configurations: 'specification/containerservice/resource-manager/Microsoft.ContainerService/nodecustomization/tspconfig.yaml', and CommitSHA: '431bfdd102a3a4f63b74380462b055f0c1fc5f2f' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6837270 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://azsdk-releaseplan-dashboard-hveph5aqhhcfhtgu.westus-01.azurewebsites.net/?releaseplan=36534 Submitted by: v-ruih@microsoft.com

Copilot AI balanced review requested due to automatic review settings September 15, 2026 08:32
@azure-sdk-automation azure-sdk-automation Bot added the auto-release When merged to main, release pipelines for this PR's changed packages trigger automatically. label Sep 15, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
9 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The broad new preview API surface warrants final human API and release validation.

Pull request overview

Adds the preview azure-mgmt-containerservicenodecustomization management package generated from the 2025-09-02-preview TypeSpec specification.

Changes:

  • Adds synchronous and asynchronous clients, models, and operations.
  • Adds package metadata, documentation, samples, and generated tests.
  • Registers the package in Containerservice CI.

Package prefix: sdk/containerservice/azure-mgmt-containerservicenodecustomization/

File summaries
File Description
sdk/containerservice/ci.yml Registers the package for CI.
CHANGELOG.md Records the initial preview release.
LICENSE Adds the MIT license.
MANIFEST.in Configures source-package contents.
README.md Documents installation and authentication.
_metadata.json Records generation metadata.
api.md Captures the generated API surface.
api.metadata.yml Records API metadata and hashes.
apiview-properties.json Maps cross-language API definitions.
dev_requirements.txt Adds development dependencies.
pyproject.toml Configures package build and release metadata.
tsp-location.yaml Records the TypeSpec source location.
generated_samples/node_customizations_create_or_update.py Demonstrates resource creation.
generated_samples/node_customizations_delete.py Demonstrates resource deletion.
generated_samples/node_customizations_delete_version.py Demonstrates version deletion.
generated_samples/node_customizations_get.py Demonstrates resource retrieval.
generated_samples/node_customizations_get_version.py Demonstrates version retrieval.
generated_samples/node_customizations_list_by_resource_group.py Demonstrates resource-group listing.
generated_samples/node_customizations_list_by_subscription.py Demonstrates subscription listing.
generated_samples/node_customizations_list_versions.py Demonstrates version listing.
generated_samples/node_customizations_update.py Demonstrates resource updates.
generated_samples/operations_list.py Demonstrates provider-operation listing.
generated_tests/conftest.py Configures generated test sanitizers.
generated_tests/test_container_service_node_customizations_operations.py Adds generated synchronous operation tests.
generated_tests/test_container_service_node_customizations_operations_async.py Adds generated asynchronous operation tests.
generated_tests/test_container_service_operations.py Adds synchronous provider-operation tests.
generated_tests/test_container_service_operations_async.py Adds asynchronous provider-operation tests.
azure/__init__.py Defines the Azure namespace package.
azure/mgmt/__init__.py Defines the management namespace package.
azure/mgmt/containerservicenodecustomization/__init__.py Exports the synchronous client.
azure/mgmt/containerservicenodecustomization/_client.py Implements the synchronous client.
azure/mgmt/containerservicenodecustomization/_configuration.py Configures synchronous policies.
azure/mgmt/containerservicenodecustomization/_patch.py Provides a package customization hook.
azure/mgmt/containerservicenodecustomization/_version.py Defines version 1.0.0b1.
azure/mgmt/containerservicenodecustomization/py.typed Marks the package as typed.
azure/mgmt/containerservicenodecustomization/types.py Defines request dictionaries.
azure/mgmt/containerservicenodecustomization/_utils/__init__.py Initializes generated utilities.
azure/mgmt/containerservicenodecustomization/_utils/model_base.py Provides generated model infrastructure.
azure/mgmt/containerservicenodecustomization/_utils/serialization.py Provides serialization infrastructure.
azure/mgmt/containerservicenodecustomization/_utils/utils.py Provides ETag helpers.
azure/mgmt/containerservicenodecustomization/models/__init__.py Exports models and enums.
azure/mgmt/containerservicenodecustomization/models/_enums.py Defines service enums.
azure/mgmt/containerservicenodecustomization/models/_models.py Defines resource models.
azure/mgmt/containerservicenodecustomization/models/_patch.py Provides a model customization hook.
azure/mgmt/containerservicenodecustomization/operations/__init__.py Exports synchronous operations.
azure/mgmt/containerservicenodecustomization/operations/_operations.py Implements synchronous operations.
azure/mgmt/containerservicenodecustomization/operations/_patch.py Provides an operation customization hook.
azure/mgmt/containerservicenodecustomization/aio/__init__.py Exports the asynchronous client.
azure/mgmt/containerservicenodecustomization/aio/_client.py Implements the asynchronous client.
azure/mgmt/containerservicenodecustomization/aio/_configuration.py Configures asynchronous policies.
azure/mgmt/containerservicenodecustomization/aio/_patch.py Provides an asynchronous customization hook.
azure/mgmt/containerservicenodecustomization/aio/operations/__init__.py Exports asynchronous operations.
azure/mgmt/containerservicenodecustomization/aio/operations/_operations.py Implements asynchronous operations.
azure/mgmt/containerservicenodecustomization/aio/operations/_patch.py Provides an asynchronous operation hook.
Review details
  • Files reviewed: 54/54 changed files
  • Comments generated: 0
  • Review effort level: Balanced

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

@ChenxiJiang333 ChenxiJiang333 added the mgmt-review-needed PR for Mgmt SDK is ready to review label Sep 17, 2026
@ChenxiJiang333

Copy link
Copy Markdown
Member

csharp change only

@github-actions

Copy link
Copy Markdown
Contributor

Management SDK PR review

Findings: None.

Unverified checks

Unverified checks: None.

Breaking-change attribution

Package: sdk/containerservice/azure-mgmt-containerservicenodecustomization | Release: 1.0.0b1 (2026-09-15)

No newly added or modified Breaking Changes entries were found; this release's only changelog entry is "Other Changes: Initial version" (no Breaking Changes section present). Collection evidence for this package was recorded as unverified: the merge-base revision (c03cb810545614e99ca0df2414918db3f89e21b0) predates this package's existence, so _metadata.json, tsp-location.yaml, api.metadata.yml, and pyproject.toml all returned 404 at that revision, and no previous release heading was found at the merge base. This is expected for a brand-new package's first release rather than evidence of a missed comparison, but per the collection status it should still be flagged: this package's changelog history could not be fully verified end-to-end and should be treated as needing human confirmation that no breaking-change section was omitted.

Review summary

  • Package reviewed: sdk/containerservice/azure-mgmt-containerservicenodecustomization (new package, first release 1.0.0b1, API version 2025-09-02-preview, unchanged between first and latest PR revision).
  • Checks completed: version consistency (_version.py 1.0.0b1 matches CHANGELOG.md), preview API version → beta SDK version requirement, pyproject.toml stability flags (is_stable = false, Development Status :: 4 - Beta), client __init__ signature order (credential, subscription_id, base_url) in _client.py, client name consistency across _client.py (ContainerServiceClient), README.md, and pyproject.toml title, README authentication snippet correctness, and the changelog release date (2026-09-15, not more than 3 weeks in the future).
  • No rule violations were identified. Breaking-change collection for this initial release was unverified due to the package not existing at the merge base (see attribution section above) — flagged for human awareness only, not as a rule violation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-release When merged to main, release pipelines for this PR's changed packages trigger automatically. mgmt-review-needed PR for Mgmt SDK is ready to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants