This repository was archived by the owner on May 7, 2024. It is now read-only.
Fix example for files with sizes divisible with BLOCKSIZE - #11
Open
Tomáš Fejfar (tomasfejfar) wants to merge 1 commit into
Open
Tomáš Fejfar (tomasfejfar) wants to merge 1 commit into
Tomáš Fejfar (tomasfejfar) wants to merge 1 commit into
Conversation
https://twitter.com/tomasfejfar/status/1391468977424064519 If filesize is 8 * 1024 * 1024 this will generate 3 requests. The last one will be 0 bytes and fail with invalid content-length=0 header.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://twitter.com/tomasfejfar/status/1391468977424064519
If filesize is 8 * 1024 * 1024 this will generate 3 requests. The last one will be 0 bytes and fail with invalid content-length=0 header.