eng, Allow preserving designated libraries during SDK sync - #50487
Merged
Weidong Xu (weidongxu-microsoft) merged 3 commits intoSep 17, 2026
Merged
Weidong Xu (weidongxu-microsoft) merged 3 commits into
Weidong Xu (weidongxu-microsoft) merged 3 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: bbb8f8a7-8cb7-4e00-8c51-872dee15fcc9
Weidong Xu (weidongxu-microsoft)
requested review from
Mike Harder (mikeharder) and
Ray Chen (raych1)
as code owners
September 16, 2026 14:31
Copilot started reviewing on behalf of
Weidong Xu (weidongxu-microsoft)
September 16, 2026 14:31
View session
|
Azure Pipelines: Successfully started running 1 pipeline(s). 35 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues were identified.
Pull request overview
This PR adds an opt-out for upgrading OpenAI TypeSpec during emitter synchronization while preserving the existing default behavior.
Changes:
- Adds and forwards the
UpgradeOpenAITypeSpecpipeline option. - Preserves the existing OpenAI TypeSpec pin when disabled.
File summaries
| File | Description |
|---|---|
eng/pipelines/scripts/sync_emitter.py |
Implements optional OpenAI TypeSpec upgrade behavior. |
eng/pipelines/post-publish-emitter.yaml |
Adds and passes the pipeline parameter. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: bbb8f8a7-8cb7-4e00-8c51-872dee15fcc9
Weidong Xu (weidongxu-microsoft)
marked this pull request as draft
September 16, 2026 14:44
Weidong Xu (weidongxu-microsoft)
marked this pull request as ready for review
September 17, 2026 07:20
Weidong Xu (weidongxu-microsoft)
requested a review
from Xiaofei Cao (XiaofeiCao)
September 17, 2026 07:20
|
Azure Pipelines: Successfully started running 1 pipeline(s). 35 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Xiaofei Cao (XiaofeiCao)
approved these changes
Sep 17, 2026
Weidong Xu (weidongxu-microsoft)
deleted the
feature/optional-openai-typespec-upgrade
branch
September 17, 2026 08:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UpgradeDesignatedLibrariespipeline boolean, defaulting totrue.sync_emitter.pyas--upgrade-designated-libraries.By default, behavior is unchanged: libraries sourced from
azure-rest-api-specsor npm latest are upgraded. Disabling the option isolates an emitter regeneration from independently versioned designated library updates.Validation
For #50481, where sync openai-typespec lib from azure-rest-api-specs caused large diff