Sync eng/common directory with azure-sdk-tools for PR 17035 - #50473
Open
azure-sdk-automation[bot] wants to merge 2 commits into
Open
azure-sdk-automation[bot] wants to merge 2 commits into
azure-sdk-automation[bot] wants to merge 2 commits into
Conversation
Fixes #16614 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
azure-sdk-automation
Bot
added
EngSys
|
Azure Pipelines: Successfully started running 1 pipeline(s). 35 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Copilot started reviewing on behalf of
Microsoft Azure (Azure)
September 15, 2026 22:20
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Avoid repeated GitHub logins for each artifact by logging in once per job and sharing the token.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Synchronizes shared Azure Pipelines templates with azure-sdk-tools PR 17035 to support conditional GitHub authentication.
Changes:
- Adds token and condition handling to REST API verification.
- Adds configurable conditions to GitHub login steps.
File summaries
| File | Summary |
|---|---|
eng/common/pipelines/templates/steps/verify-restapi-spec-location.yml |
Adds authentication and condition handling; should reuse one login token per job rather than logging in per artifact. |
eng/common/pipelines/templates/steps/login-to-github.yml |
Adds configurable task conditions. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+19
to
+24
| - ${{ if eq(parameters.AuthToken, '') }}: | ||
| - template: /eng/common/pipelines/templates/steps/login-to-github.yml | ||
| parameters: | ||
| TokenOwners: | ||
| - Azure | ||
| Condition: ${{ parameters.Condition }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#17035 See eng/common workflow