[AutoPR azure-resourcemanager-imagebuilder]-generated-from-SDK Generation - Java-6324648#49224
Open
azure-sdk wants to merge 2 commits into
Open
[AutoPR azure-resourcemanager-imagebuilder]-generated-from-SDK Generation - Java-6324648#49224azure-sdk wants to merge 2 commits into
azure-sdk wants to merge 2 commits into
Conversation
…t.VirtualMachineImages/ImageBuilder/tspconfig.yaml', API Version: 2025-10-01, SDK Release Type: stable, and CommitSHA: '7c184b1698a04ad263664eafafc3287a288d34d9' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6324648 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates azure-resourcemanager-imagebuilder to a TypeSpec-generated SDK targeting ARM Image Builder API version 2025-10-01, and promotes the package from 1.3.0-beta.1 to 1.3.0 (stable).
Changes:
- Regenerates the Image Builder management client and models from TypeSpec, including new features like
additionalDataDisks,workloadoptimization, andreplicationMode. - Updates samples/tests and documentation to TypeSpec generation output and newer azure-core surface (e.g.,
AzureCloud). - Updates build/versioning metadata for a stable release (POM version +
eng/versioning/version_client.txt) and adds runtime properties for user-agent versioning.
Reviewed changes
Copilot reviewed 101 out of 163 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| eng/versioning/version_client.txt | Updates tracked version for stable 1.3.0 release. |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/pom.xml | Bumps artifact to 1.3.0 and updates description/api-version metadata. |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/README.md | Updates package version and authentication snippet to use AzureCloud. |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/tsp-location.yaml | Adds TypeSpec spec location metadata for this SDK. |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/src/main/java/module-info.java | Opens implementation.models for serialization. |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/src/main/resources/azure-resourcemanager-imagebuilder.properties | Adds properties file used for runtime SDK version lookup. |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/src/main/java/com/azure/resourcemanager/imagebuilder/package-info.java | Updates package JavaDoc to new service naming/description. |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/src/main/java/com/azure/resourcemanager/imagebuilder/models/package-info.java | Updates models package JavaDoc to new service naming/description. |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/src/main/java/com/azure/resourcemanager/imagebuilder/implementation/package-info.java | Updates implementation package JavaDoc to new service naming/description. |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/src/main/java/com/azure/resourcemanager/imagebuilder/fluent/package-info.java | Updates fluent package JavaDoc to new service naming/description. |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/src/main/java/com/azure/resourcemanager/imagebuilder/fluent/models/package-info.java | Updates fluent models package JavaDoc to new service naming/description. |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/src/main/java/com/azure/resourcemanager/imagebuilder/ImageBuilderManager.java | Switches user-agent versioning to read from the new properties resource; minor member reordering. |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/src/main/java/com/azure/resourcemanager/imagebuilder/implementation/ImageBuilderClientBuilder.java | Reorders/clarifies builder fields for endpoint/subscriptionId and updates client construction. |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/src/main/java/com/azure/resourcemanager/imagebuilder/fluent/ImageBuilderClient.java | Reorders accessors and swaps client getter order (Operations vs Templates) in interface. |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/src/main/java/com/azure/resourcemanager/imagebuilder/implementation/ImageTemplateImpl.java | Adds additionalDataDisks getters/setters and adjusts isInCreateMode guard. |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/src/main/java/com/azure/resourcemanager/imagebuilder/models/ImageTemplate.java | Adds additionalDataDisks() + fluent definition stage WithAdditionalDataDisks. |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/src/main/java/com/azure/resourcemanager/imagebuilder/models/DataDisk.java | New model type for additionalDataDisks. |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/src/main/java/com/azure/resourcemanager/imagebuilder/models/ReplicationMode.java | New expandable enum for shared image replication mode. |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/src/main/java/com/azure/resourcemanager/imagebuilder/models/WorkloadOptimizationState.java | New enum for workload optimization state. |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/src/main/java/com/azure/resourcemanager/imagebuilder/models/ImageTemplatePropertiesOptimizeWorkload.java | New model for workload optimization settings. |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/src/main/java/com/azure/resourcemanager/imagebuilder/models/ImageTemplatePropertiesOptimize.java | Adds workload property serialization/deserialization. |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/src/main/java/com/azure/resourcemanager/imagebuilder/models/ImageTemplateSharedImageDistributor.java | Adds replicationMode property serialization/deserialization. |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/src/main/java/com/azure/resourcemanager/imagebuilder/models/OperationDisplay.java | Shifts to immutable/read-only style generation (constructor/setter surface changes). |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/src/main/java/com/azure/resourcemanager/imagebuilder/models/ProvisioningError.java | Shifts to immutable/read-only style generation (constructor/setter surface changes). |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/src/main/java/com/azure/resourcemanager/imagebuilder/models/ImageTemplateLastRunStatus.java | Shifts to immutable/read-only style generation (constructor/setter surface changes). |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/src/main/java/com/azure/resourcemanager/imagebuilder/models/TriggerStatus.java | Makes constructor private and adjusts serialization behavior. |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/src/main/java/com/azure/resourcemanager/imagebuilder/models/TriggerProperties.java | Updates discriminator handling and (de)serialization for trigger properties. |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/src/main/java/com/azure/resourcemanager/imagebuilder/models/SourceImageTriggerProperties.java | Updates discriminator subtype for trigger properties. |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/src/main/java/com/azure/resourcemanager/imagebuilder/implementation/TriggersImpl.java | Simplifies getWithResponse mapping and reorders list methods. |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/src/main/java/com/azure/resourcemanager/imagebuilder/implementation/models/TriggerCollection.java | Moves list result model under implementation package and makes it immutable. |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/src/main/java/com/azure/resourcemanager/imagebuilder/implementation/models/RunOutputCollection.java | Moves list result model under implementation package and makes it immutable. |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/src/main/java/com/azure/resourcemanager/imagebuilder/implementation/models/OperationListResult.java | Moves list result model under implementation package and makes it immutable. |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/src/main/java/com/azure/resourcemanager/imagebuilder/implementation/models/ImageTemplateListResult.java | Moves list result model under implementation package and makes it immutable. |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/src/samples/java/com/azure/resourcemanager/imagebuilder/generated/OperationsListSamples.java | Updates x-ms-original-file annotation paths for 2025-10-01. |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/src/samples/java/com/azure/resourcemanager/imagebuilder/generated/TriggersCreateOrUpdateSamples.java | Updates x-ms-original-file annotation paths for 2025-10-01. |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/src/samples/java/com/azure/resourcemanager/imagebuilder/generated/TriggersDeleteSamples.java | Updates x-ms-original-file annotation paths for 2025-10-01. |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/src/samples/java/com/azure/resourcemanager/imagebuilder/generated/TriggersGetSamples.java | Updates x-ms-original-file annotation paths for 2025-10-01. |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/src/samples/java/com/azure/resourcemanager/imagebuilder/generated/TriggersListByImageTemplateSamples.java | Updates x-ms-original-file annotation paths for 2025-10-01. |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/src/samples/java/com/azure/resourcemanager/imagebuilder/generated/VirtualMachineImageTemplatesCancelSamples.java | Updates x-ms-original-file annotation paths for 2025-10-01. |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/src/samples/java/com/azure/resourcemanager/imagebuilder/generated/VirtualMachineImageTemplatesCreateOrUpdateSamples.java | Updates x-ms-original-file annotation paths for 2025-10-01. |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/src/samples/java/com/azure/resourcemanager/imagebuilder/generated/VirtualMachineImageTemplatesDeleteSamples.java | Updates x-ms-original-file annotation paths for 2025-10-01. |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/src/samples/java/com/azure/resourcemanager/imagebuilder/generated/VirtualMachineImageTemplatesGetByResourceGroupSamples.java | Updates x-ms-original-file annotation paths for 2025-10-01. |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/src/samples/java/com/azure/resourcemanager/imagebuilder/generated/VirtualMachineImageTemplatesGetRunOutputSamples.java | Updates x-ms-original-file annotation paths for 2025-10-01. |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/src/samples/java/com/azure/resourcemanager/imagebuilder/generated/VirtualMachineImageTemplatesListByResourceGroupSamples.java | Updates x-ms-original-file annotation paths for 2025-10-01. |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/src/samples/java/com/azure/resourcemanager/imagebuilder/generated/VirtualMachineImageTemplatesListRunOutputsSamples.java | Updates x-ms-original-file annotation paths for 2025-10-01. |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/src/samples/java/com/azure/resourcemanager/imagebuilder/generated/VirtualMachineImageTemplatesListSamples.java | Updates x-ms-original-file annotation paths for 2025-10-01. |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/src/samples/java/com/azure/resourcemanager/imagebuilder/generated/VirtualMachineImageTemplatesRunSamples.java | Updates x-ms-original-file annotation paths for 2025-10-01. |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/src/samples/java/com/azure/resourcemanager/imagebuilder/generated/VirtualMachineImageTemplatesUpdateSamples.java | Updates x-ms-original-file annotation paths for 2025-10-01. |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/src/test/java/com/azure/resourcemanager/imagebuilder/generated/DataDiskTests.java | Adds serialization tests for new DataDisk model. |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/src/test/java/com/azure/resourcemanager/imagebuilder/generated/ImageTemplatePropertiesOptimizeWorkloadTests.java | Adds tests for new workload optimization model. |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/src/test/java/com/azure/resourcemanager/imagebuilder/generated/ImageTemplatePropertiesOptimizeTests.java | Updates optimize tests to include new workload property. |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/src/test/java/com/azure/resourcemanager/imagebuilder/generated/*Tests.java | Broadly updates generated unit tests to TypeSpec output values and shapes. |
| sdk/imagebuilder/azure-resourcemanager-imagebuilder/src/test/java/com/azure/resourcemanager/imagebuilder/generated/*MockTests.java | Updates generated mock tests to use AzureCloud.AZURE_PUBLIC_CLOUD and new values. |
Comments suppressed due to low confidence (1)
sdk/imagebuilder/azure-resourcemanager-imagebuilder/src/main/java/com/azure/resourcemanager/imagebuilder/models/TriggerStatus.java:76
TriggerStatus.toJsoncurrently writes an empty JSON object ({}), droppingcode,message, andtime. Even if this type is primarily response-only, this makes round-tripping viaBinaryData.fromObject(...)/toJsonincorrect and inconsistent with other model types in this library. Consider serializing the fields (or removingJsonSerializableif it should never be serialized).
weidongxu-microsoft
approved these changes
May 20, 2026
Member
weidongxu-microsoft
left a comment
There was a problem hiding this comment.
@XiaofeiCao for review
XiaofeiCao
approved these changes
May 20, 2026
weidongxu-microsoft
approved these changes
May 20, 2026
Member
weidongxu-microsoft
left a comment
There was a problem hiding this comment.
Approved. All CI checks pass. Stable api-version 2025-10-01, standard regeneration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configurations: 'specification/imagebuilder/resource-manager/Microsoft.VirtualMachineImages/ImageBuilder/tspconfig.yaml', API Version: 2025-10-01, SDK Release Type: stable, and CommitSHA: '7c184b1698a04ad263664eafafc3287a288d34d9' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6324648 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://azsdk-releaseplan-dashboard-hveph5aqhhcfhtgu.westus-01.azurewebsites.net/?releaseplan=2212 Submitted by: kofiforson@microsoft.com