[EventGrid] Regenerate system events for May 2026 release#49159
Open
rajeshka wants to merge 5 commits into
Open
[EventGrid] Regenerate system events for May 2026 release#49159rajeshka wants to merge 5 commits into
rajeshka wants to merge 5 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the azure-messaging-eventgrid-systemevents TypeSpec input to a newer azure-rest-api-specs commit and regenerates the Java system events models to pick up new ACS Messaging/IncomingCall properties and Chat sequenceId/retention-policy additions.
Changes:
- Updated
tsp-location.yamlto point at the reorganized spec directory and a newer pinned commit. - Regenerated system event models/metadata, adding new ACS properties (e.g., BSUID fields, on-behalf-of caller/callee) and Chat
sequenceId. - Added new retention policy and deletion-reason models and wired them into affected chat thread events.
Reviewed changes
Copilot reviewed 22 out of 23 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/eventgrid/azure-messaging-eventgrid-systemevents/tsp-location.yaml | Updates spec directory path and pinned azure-rest-api-specs commit for regeneration. |
| sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/resources/META-INF/azure-messaging-eventgrid-systemevents_metadata.json | Regenerated cross-language type mappings and generated file inventory. |
| sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/java/com/azure/messaging/eventgrid/systemevents/models/AcsMessageReceivedEventData.java | Adds fromBsuid and serializes/deserializes fromBSUID. |
| sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/java/com/azure/messaging/eventgrid/systemevents/models/AcsMessageDeliveryStatusUpdatedEventData.java | Adds toBsuid and serializes/deserializes toBSUID. |
| sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/java/com/azure/messaging/eventgrid/systemevents/models/AcsIncomingCallEventData.java | Updates on-behalf-of semantics and adds onBehalfOfCaller (onBehalfOf). |
| sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/java/com/azure/messaging/eventgrid/systemevents/models/AcsChatTypingIndicatorReceivedInThreadEventData.java | Adds sequenceId plumbing to typing-indicator events. |
| sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/java/com/azure/messaging/eventgrid/systemevents/models/AcsChatThreadRetentionPolicyKind.java | New expandable enum for retention policy kind. |
| sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/java/com/azure/messaging/eventgrid/systemevents/models/AcsChatThreadRetentionPolicy.java | New retention policy model with JSON serialization support. |
| sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/java/com/azure/messaging/eventgrid/systemevents/models/AcsChatThreadPropertiesUpdatedPerUserEventData.java | Adds retentionPolicy to per-user thread-properties updates. |
| sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/java/com/azure/messaging/eventgrid/systemevents/models/AcsChatThreadPropertiesUpdatedEventData.java | Adds retentionPolicy to thread-properties updates. |
| sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/java/com/azure/messaging/eventgrid/systemevents/models/AcsChatThreadDeletedReason.java | New expandable enum for thread deletion reason. |
| sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/java/com/azure/messaging/eventgrid/systemevents/models/AcsChatThreadDeletedEventData.java | Adds reason field to thread-deleted event data. |
| sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/java/com/azure/messaging/eventgrid/systemevents/models/AcsChatThreadCreatedWithUserEventData.java | Adds retentionPolicy to thread-created-with-user event data. |
| sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/java/com/azure/messaging/eventgrid/systemevents/models/AcsChatThreadCreatedEventData.java | Adds retentionPolicy to thread-created event data. |
| sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/java/com/azure/messaging/eventgrid/systemevents/models/AcsChatMessageReceivedInThreadEventData.java | Adds sequenceId plumbing to message-received-in-thread events. |
| sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/java/com/azure/messaging/eventgrid/systemevents/models/AcsChatMessageReceivedEventData.java | Adds sequenceId plumbing to message-received events. |
| sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/java/com/azure/messaging/eventgrid/systemevents/models/AcsChatMessageEventInThreadBaseProperties.java | Adds base sequenceId support for in-thread chat message events. |
| sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/java/com/azure/messaging/eventgrid/systemevents/models/AcsChatMessageEventBaseProperties.java | Adds base sequenceId support for chat message events. |
| sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/java/com/azure/messaging/eventgrid/systemevents/models/AcsChatMessageEditedInThreadEventData.java | Adds sequenceId plumbing to message-edited-in-thread events. |
| sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/java/com/azure/messaging/eventgrid/systemevents/models/AcsChatMessageEditedEventData.java | Adds sequenceId plumbing to message-edited events. |
| sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/java/com/azure/messaging/eventgrid/systemevents/models/AcsChatMessageDeletedInThreadEventData.java | Adds sequenceId plumbing to message-deleted-in-thread events. |
| sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/java/com/azure/messaging/eventgrid/systemevents/models/AcsChatMessageDeletedEventData.java | Adds sequenceId plumbing to message-deleted events. |
| sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/java/com/azure/messaging/eventgrid/systemevents/models/AcsChatAzureBotCommandReceivedInThreadEventData.java | Adds sequenceId plumbing to bot-command-in-thread events. |
* Remove duplicate sequenceId field/getter override in 8 ACS chat subclasses; route deserialization through the package-private setSequenceId(Long) on the base classes so the inherited field is populated correctly. Files updated: - AcsChatMessageReceivedEventData.java - AcsChatMessageReceivedInThreadEventData.java - AcsChatTypingIndicatorReceivedInThreadEventData.java - AcsChatAzureBotCommandReceivedInThreadEventData.java - AcsChatMessageEditedEventData.java - AcsChatMessageEditedInThreadEventData.java - AcsChatMessageDeletedEventData.java - AcsChatMessageDeletedInThreadEventData.java * Add deserialization unit tests for the new fromBSUID / toBSUID fields on AcsMessageReceivedEventData and AcsMessageDeliveryStatusUpdatedEventData, plus matching test JSON fixtures under src/test/resources/testJsons/. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ng, osrolling)
The May 2026 system events regeneration introduced new identifiers from
upstream TypeSpec that trip the cspell check in CI:
* BSUID / Bsuid - ACS Messaging recipient/sender identifier used in
AcsMessageDeliveryStatusUpdatedEventData and AcsMessageReceivedEventData
* OSSCHEDULING - in VMSS lifecycle hook event UpgradeAutoOSScheduling
* OSROLLING - in VMSS lifecycle hook event UpgradeAutoOSRollingBatchStarting
These are legitimate identifiers from the generated models, not typos,
so they belong on the sdk/eventgrid/** cspell allowlist.
Verified locally with cspell - 0 issues across the 3 affected files.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The CI 'Verify Swagger and TypeSpec Code Generation' task failed because the previous Copilot review feedback commit (00c3604) hand-edited these 8 generated files to remove what looked like duplicate sequenceId fields. However the upstream TypeSpec (Microsoft.EventGrid.SystemEvents @ commit 7089f3d2 in azure-rest-api-specs) defines sequenceId on each of these concrete chat event types, so tsp-client emits a per-subclass field + @OverRide getter intentionally. Running 'tsp-client update' locally reproduces CI's diff exactly: 8 files, +136/-8 lines, adding back the @generated private Long sequenceId field, the @OverRide getSequenceId() accessor, and switching deserialization to write directly to this.sequenceId instead of setSequenceId(). The underlying 'duplicate field with the parent' concern Copilot raised is a TypeSpec authoring choice and is out of scope for this regen PR; it can be addressed in a follow-up against azure-rest-api-specs if needed. Affected files: - AcsChatAzureBotCommandReceivedInThreadEventData.java - AcsChatMessageDeletedEventData.java - AcsChatMessageDeletedInThreadEventData.java - AcsChatMessageEditedEventData.java - AcsChatMessageEditedInThreadEventData.java - AcsChatMessageReceivedEventData.java - AcsChatMessageReceivedInThreadEventData.java - AcsChatTypingIndicatorReceivedInThreadEventData.java Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Regenerate
azure-messaging-eventgrid-systemeventspackage to include latest system events changes from azure-rest-api-specs.Why
Include new system events from the following merged spec PRs:
Changes
tsp-location.yamlto point to latest spec commit7089f3d2a4ed7e765d66f5f5e3be0b8b1eed6c1aAzure.Messaging.EventGrid.SystemEventstodata-plane/EventGridSystemEvents(spec repo reorganization)tsp-client updateTesting
CI pipeline validation pending.