Skip to content

[EventGrid] Regenerate system events for May 2026 release#49159

Open
rajeshka wants to merge 5 commits into
mainfrom
eventgrid/system-events-update-may2026
Open

[EventGrid] Regenerate system events for May 2026 release#49159
rajeshka wants to merge 5 commits into
mainfrom
eventgrid/system-events-update-may2026

Conversation

@rajeshka
Copy link
Copy Markdown
Member

@rajeshka rajeshka commented May 12, 2026

What

Regenerate azure-messaging-eventgrid-systemevents package to include latest system events changes from azure-rest-api-specs.

Why

Include new system events from the following merged spec PRs:

Changes

  • Updated tsp-location.yaml to point to latest spec commit 7089f3d2a4ed7e765d66f5f5e3be0b8b1eed6c1a
  • Updated spec directory path from Azure.Messaging.EventGrid.SystemEvents to data-plane/EventGridSystemEvents (spec repo reorganization)
  • Regenerated Java client code via tsp-client update

Testing

CI pipeline validation pending.

Update system events to include changes from:
- PR #42138: Adding new properties for ACSMessaging and IncomingCall events
- PR #39046: Update Chat event to include sequenceId

Updated tsp-location.yaml to point to latest azure-rest-api-specs commit 6ffd9e58a8c976b93c2d9d0db15a63907262d020
Copilot AI review requested due to automatic review settings May 12, 2026 21:35
@rajeshka rajeshka requested review from a team, samvaity and srnagar as code owners May 12, 2026 21:35
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the azure-messaging-eventgrid-systemevents TypeSpec input to a newer azure-rest-api-specs commit and regenerates the Java system events models to pick up new ACS Messaging/IncomingCall properties and Chat sequenceId/retention-policy additions.

Changes:

  • Updated tsp-location.yaml to point at the reorganized spec directory and a newer pinned commit.
  • Regenerated system event models/metadata, adding new ACS properties (e.g., BSUID fields, on-behalf-of caller/callee) and Chat sequenceId.
  • Added new retention policy and deletion-reason models and wired them into affected chat thread events.

Reviewed changes

Copilot reviewed 22 out of 23 changed files in this pull request and generated 10 comments.

Show a summary per file
File Description
sdk/eventgrid/azure-messaging-eventgrid-systemevents/tsp-location.yaml Updates spec directory path and pinned azure-rest-api-specs commit for regeneration.
sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/resources/META-INF/azure-messaging-eventgrid-systemevents_metadata.json Regenerated cross-language type mappings and generated file inventory.
sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/java/com/azure/messaging/eventgrid/systemevents/models/AcsMessageReceivedEventData.java Adds fromBsuid and serializes/deserializes fromBSUID.
sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/java/com/azure/messaging/eventgrid/systemevents/models/AcsMessageDeliveryStatusUpdatedEventData.java Adds toBsuid and serializes/deserializes toBSUID.
sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/java/com/azure/messaging/eventgrid/systemevents/models/AcsIncomingCallEventData.java Updates on-behalf-of semantics and adds onBehalfOfCaller (onBehalfOf).
sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/java/com/azure/messaging/eventgrid/systemevents/models/AcsChatTypingIndicatorReceivedInThreadEventData.java Adds sequenceId plumbing to typing-indicator events.
sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/java/com/azure/messaging/eventgrid/systemevents/models/AcsChatThreadRetentionPolicyKind.java New expandable enum for retention policy kind.
sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/java/com/azure/messaging/eventgrid/systemevents/models/AcsChatThreadRetentionPolicy.java New retention policy model with JSON serialization support.
sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/java/com/azure/messaging/eventgrid/systemevents/models/AcsChatThreadPropertiesUpdatedPerUserEventData.java Adds retentionPolicy to per-user thread-properties updates.
sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/java/com/azure/messaging/eventgrid/systemevents/models/AcsChatThreadPropertiesUpdatedEventData.java Adds retentionPolicy to thread-properties updates.
sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/java/com/azure/messaging/eventgrid/systemevents/models/AcsChatThreadDeletedReason.java New expandable enum for thread deletion reason.
sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/java/com/azure/messaging/eventgrid/systemevents/models/AcsChatThreadDeletedEventData.java Adds reason field to thread-deleted event data.
sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/java/com/azure/messaging/eventgrid/systemevents/models/AcsChatThreadCreatedWithUserEventData.java Adds retentionPolicy to thread-created-with-user event data.
sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/java/com/azure/messaging/eventgrid/systemevents/models/AcsChatThreadCreatedEventData.java Adds retentionPolicy to thread-created event data.
sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/java/com/azure/messaging/eventgrid/systemevents/models/AcsChatMessageReceivedInThreadEventData.java Adds sequenceId plumbing to message-received-in-thread events.
sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/java/com/azure/messaging/eventgrid/systemevents/models/AcsChatMessageReceivedEventData.java Adds sequenceId plumbing to message-received events.
sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/java/com/azure/messaging/eventgrid/systemevents/models/AcsChatMessageEventInThreadBaseProperties.java Adds base sequenceId support for in-thread chat message events.
sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/java/com/azure/messaging/eventgrid/systemevents/models/AcsChatMessageEventBaseProperties.java Adds base sequenceId support for chat message events.
sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/java/com/azure/messaging/eventgrid/systemevents/models/AcsChatMessageEditedInThreadEventData.java Adds sequenceId plumbing to message-edited-in-thread events.
sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/java/com/azure/messaging/eventgrid/systemevents/models/AcsChatMessageEditedEventData.java Adds sequenceId plumbing to message-edited events.
sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/java/com/azure/messaging/eventgrid/systemevents/models/AcsChatMessageDeletedInThreadEventData.java Adds sequenceId plumbing to message-deleted-in-thread events.
sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/java/com/azure/messaging/eventgrid/systemevents/models/AcsChatMessageDeletedEventData.java Adds sequenceId plumbing to message-deleted events.
sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/java/com/azure/messaging/eventgrid/systemevents/models/AcsChatAzureBotCommandReceivedInThreadEventData.java Adds sequenceId plumbing to bot-command-in-thread events.

rajeshka and others added 4 commits May 13, 2026 10:35
Regenerated from azure-rest-api-specs commit 7089f3d2a4ed7e765d66f5f5e3be0b8b1eed6c1a
which includes:
- PR #42138: Adding new properties for ACSMessaging and IncomingCall events
- PR #39046: Update Chat event to include sequenceId
- PR #40499: Add VMSS Lifecycle Hook events to EG ST
* Remove duplicate sequenceId field/getter override in 8 ACS chat
  subclasses; route deserialization through the package-private
  setSequenceId(Long) on the base classes so the inherited field is
  populated correctly.

  Files updated:
   - AcsChatMessageReceivedEventData.java
   - AcsChatMessageReceivedInThreadEventData.java
   - AcsChatTypingIndicatorReceivedInThreadEventData.java
   - AcsChatAzureBotCommandReceivedInThreadEventData.java
   - AcsChatMessageEditedEventData.java
   - AcsChatMessageEditedInThreadEventData.java
   - AcsChatMessageDeletedEventData.java
   - AcsChatMessageDeletedInThreadEventData.java

* Add deserialization unit tests for the new fromBSUID / toBSUID
  fields on AcsMessageReceivedEventData and
  AcsMessageDeliveryStatusUpdatedEventData, plus matching test
  JSON fixtures under src/test/resources/testJsons/.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ng, osrolling)

The May 2026 system events regeneration introduced new identifiers from

upstream TypeSpec that trip the cspell check in CI:

  * BSUID / Bsuid - ACS Messaging recipient/sender identifier used in

    AcsMessageDeliveryStatusUpdatedEventData and AcsMessageReceivedEventData

  * OSSCHEDULING - in VMSS lifecycle hook event UpgradeAutoOSScheduling

  * OSROLLING   - in VMSS lifecycle hook event UpgradeAutoOSRollingBatchStarting

These are legitimate identifiers from the generated models, not typos,

so they belong on the sdk/eventgrid/** cspell allowlist.

Verified locally with cspell - 0 issues across the 3 affected files.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The CI 'Verify Swagger and TypeSpec Code Generation' task failed because

the previous Copilot review feedback commit (00c3604) hand-edited these

8 generated files to remove what looked like duplicate sequenceId fields.

However the upstream TypeSpec (Microsoft.EventGrid.SystemEvents @ commit

7089f3d2 in azure-rest-api-specs) defines sequenceId on each of these

concrete chat event types, so tsp-client emits a per-subclass field +

@OverRide getter intentionally.

Running 'tsp-client update' locally reproduces CI's diff exactly: 8 files,

+136/-8 lines, adding back the @generated private Long sequenceId field,

the @OverRide getSequenceId() accessor, and switching deserialization to

write directly to this.sequenceId instead of setSequenceId().

The underlying 'duplicate field with the parent' concern Copilot raised is

a TypeSpec authoring choice and is out of scope for this regen PR; it can

be addressed in a follow-up against azure-rest-api-specs if needed.

Affected files:

  - AcsChatAzureBotCommandReceivedInThreadEventData.java

  - AcsChatMessageDeletedEventData.java

  - AcsChatMessageDeletedInThreadEventData.java

  - AcsChatMessageEditedEventData.java

  - AcsChatMessageEditedInThreadEventData.java

  - AcsChatMessageReceivedEventData.java

  - AcsChatMessageReceivedInThreadEventData.java

  - AcsChatTypingIndicatorReceivedInThreadEventData.java

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants