You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am not familiar with E2E-test situation for this repo, but want to make sure the feature is validated either manually or by tests. A specific scenario to validate for is the incoming payload type when using AllVersionsAndDelete. With LatestVersion it will be T, for AVAD it will be ChangeFeedItem<T>. So the JSON representation of this CSharp class: https://learn.microsoft.com/en-us/dotnet/api/microsoft.azure.cosmos.changefeeditem-1?view=azure-dotnet-preview
+1 for the Jacob's comment. Change looks good. E2E might be required.
For E2E testing with this change, If you've already done the manual E2E, I'd happy to approve. But I'm wondering if we can write E2E testing for nodejs-library/worker/extensions if one of them are changed, We can use https://github.com/Azure/azure-functions-nodejs-e2e-tests .
+1 for the Jacob's comment. Change looks good. E2E might be required. For E2E testing with this change, If you've already done the manual E2E, I'd happy to approve. But I'm wondering if we can write E2E testing for nodejs-library/worker/extensions if one of them are changed, We can use https://github.com/Azure/azure-functions-nodejs-e2e-tests .
Emulator do not support this. I will be creating a new sample for this feature and test locally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Cosmos DB Change Feed mode support and validation so changeFeedMode is surfaced in types and preserved through function registration metadata.
Changes
Version