Skip to content

[azure-iot] Exempt digital-twin update authentication default from lint - #10433

Merged
Ethan Yang (necusjz) merged 1 commit into
Azure:mainfrom
HangyiWang:add-azure-iot-digital-twin-lint-exemption
Oct 6, 2026
Merged

Ethan Yang (necusjz) merged 1 commit into
Azure:mainfrom
HangyiWang:add-azure-iot-digital-twin-lint-exemption

Conversation

@HangyiWang

Copy link
Copy Markdown
Contributor

Summary

Add a parameter-scoped no_parameter_defaults_for_update_commands exemption for iot hub digital-twin update / auth_type_dataplane.

The default key selects request authentication; it does not update a digital-twin property. This follows the existing exemptions for iot hub device-twin update, device-identity update, module-twin update, and other Hub update commands.

The same exemption already exists in the IoT extension repository, where release lint applies it. The index repository was missing it, causing the external-wheel linter to report a HIGH-severity finding for the published preview.

Scope

  • Only linter_exclusions.yml changes: five added lines.
  • The exemption applies to one rule on one parameter of one command.
  • No index entries, release artifacts, runtime behavior, or other lint rules change.

Related: #10432. The 1.0.0b2 index proposal remains a separate, index-only PR.

Validation

  • Loaded the published azure-iot 1.0.0b2 wheel in an isolated extension directory and ran the actual azdev 0.2.13 rule against its command table.
  • Reproduced the HIGH-severity finding with the original exclusions (exit code 1); the added exemption makes the same rule pass (exit code 0).
  • Confirmed the parsed YAML differs only by the new entry and that it exactly matches the existing device-twin update exemption.
  • git diff --check passed.

Match existing Hub update-command exemptions for auth_type_dataplane. This default selects request authentication rather than updating a resource property.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 6, 2026 03:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The narrowly scoped exemption matches established neighboring entries and the upstream extension configuration.

Review effort: Balanced
Findings: None

What changed in this PR

Adds the missing parameter-scoped lint exemption for Azure IoT digital-twin authentication defaults.

Changes:

  • Exempts auth_type_dataplane on iot hub digital-twin update from the update-default rule.
  • Aligns lint behavior with related IoT Hub commands and the IoT extension repository.
File Description
linter_exclusions.yml Adds the targeted digital-twin lint exemption.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@microsoft-github-policy-service microsoft-github-policy-service Bot added the Auto-Assign Auto assign by bot label Oct 6, 2026
@necusjz
Ethan Yang (necusjz) merged commit 5d1bb44 into Azure:main Oct 6, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants