[Quantum] Fix workspace create crash for providers without managed_application - #10415
Merged
Ethan Yang (necusjz) merged 2 commits intoOct 5, 2026
Merged
Ethan Yang (necusjz) merged 2 commits into
Ethan Yang (necusjz) merged 2 commits into
Conversation
microsoft-github-policy-service
Bot
requested review from
Ethan Yang (necusjz),
ZelinWang (wangzelin007) and
Yong Zhang (yonzhan)
September 30, 2026 19:23
v-elegacheva
marked this pull request as draft
September 30, 2026 19:24
microsoft-github-policy-service
Bot
added
Quantum
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused fix correctly reuses existing no-terms handling and has adequate regression coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes workspace creation for V2 providers without legacy marketplace associations.
Changes:
- Handles missing
managed_applicationusing existing sentinel values. - Adds helper and workspace-level regression tests.
| File | Description |
|---|---|
operations/offerings.py |
Prevents missing managed applications from crashing. |
tests/latest/test_quantum_offerings.py |
Tests provider lookup behavior and regression case. |
tests/latest/test_quantum_workspace.py |
Tests provider addition end to end. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
v-elegacheva
force-pushed
the
ekat/quantum-v2-provider-offer-fix
branch
from
September 30, 2026 21:34
3893116 to
de03e64
Compare
Collaborator
|
Quantum |
Member
|
can we check if same crash still happens in the offerings table view. transform_offerings reads offering['properties']['managedApplication']['publisherId'] with no check |
Member
|
New version should be released for this |
Collaborator
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
Zulfat Nutfullin (rigidit)
approved these changes
Oct 2, 2026
v-elegacheva
marked this pull request as ready for review
October 2, 2026 17:29
…plication Bug 55823: az quantum workspace create crashed with AttributeError when a provider has no legacy marketplace ManagedApplication association. _get_publisher_and_offer_from_provider_id now treats managed_application=None the same as the existing N/A sentinel (no terms to accept) instead of crashing, reusing the already-correct downstream handling in _provider_terms_need_acceptance/_valid_publisher_and_offer. Adds unit tests for the fixed helper plus an integration-level test on _add_quantum_providers reproducing the exact crash scenario.
v-elegacheva
force-pushed
the
ekat/quantum-v2-provider-offer-fix
branch
from
October 2, 2026 18:34
d09b4f9 to
d8613d7
Compare
Ethan Yang (necusjz)
approved these changes
Oct 5, 2026
Collaborator
|
[Release] Update index.json for extension [ quantum-1.0.0b30 ] : https://dev.azure.com/msazure/One/_build/results?buildId=184124890&view=results |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
az quantum workspace create --workspace-kind V2 -r <provider>/<sku> ...crashed with an unhandledAttributeError: 'NoneType' object has no attribute 'offer_id'for providers that have no legacy marketplaceManagedApplicationassociation. This happened even with--skip-autoadd, since that flag only skips additional auto-added providers, not ones passed explicitly via-r.Root cause
_get_publisher_and_offer_from_provider_idassumedproperties.managed_applicationis always populated (with real values, or the existingN/Asentinel meaning "no terms to accept"). For certain V2-native providers, the object itself isNone, a case the function never guarded against.Fix
Treat
managed_application is Nonethe same as the existingN/Asentinel (PUBLISHER_NOT_AVAILABLE/OFFER_NOT_AVAILABLE) instead of crashing. This reuses the already-correct downstream handling in_provider_terms_need_acceptance/_valid_publisher_and_offer(both already short-circuit on theN/Asentinel without calling the marketplace API), so no other function needed to change.Testing
_add_quantum_providersmockingcf_offeringsto return a provider with nomanaged_application, reproducing the exact failing scenario end-to-end.azdev style quantum/azdev linter quantum: both PASSED.