{k8s-extension} Migrate code to aaz-based implementation - #10407
Open
William (william051200) wants to merge 6 commits into
Open
William (william051200) wants to merge 6 commits into
William (william051200) wants to merge 6 commits into
Conversation
microsoft-github-policy-service
Bot
requested a review
from Yong Zhang (yonzhan)
September 29, 2026 05:57
Copilot started reviewing on behalf of
William (william051200)
September 29, 2026 05:58
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The AAZ invocation and output handling are correct, version requirements are aligned, and tests cover both validation outcomes.
Review effort: Balanced
Findings: None
What changed in this PR
Migrates virtual-node VM-size validation from the Compute SDK to Azure CLI’s AAZ implementation.
Changes:
- Uses
VMListSizeswith dictionary-based results. - Adds validation unit tests.
- Bumps extension and minimum CLI versions.
| File | Description |
|---|---|
setup.py |
Bumps version to 1.9.2. |
HISTORY.rst |
Records the AAZ migration. |
test_virtual_nodes.py |
Tests qualifying and non-qualifying pools. |
VirtualNodes.py |
Replaces Compute SDK VM-size lookup with AAZ. |
azext_metadata.json |
Requires Azure CLI 2.69.0. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Collaborator
|
k8s-extension |
Collaborator
|
Please fix CI issues |
Member
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration from mgmt.compute to aaz-based
Update minCliCoreVersion as VMListSizes only available since CLI 2.69.0
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install azdevrequired)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.