Validate Fleet extension types client-side - #10401
Open
Britania Rodriguez Reyes (britaniar) wants to merge 11 commits into
Open
Britania Rodriguez Reyes (britaniar) wants to merge 11 commits into
Britania Rodriguez Reyes (britaniar) wants to merge 11 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Use the 2026-06-01 Fleet ARM API for parent resource lookup per review feedback. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Keep the existing or-separated wording while adding Fleet resources. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Record create, show, list, and delete requests against a hubful staging Fleet. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Preserve the upstream 1.9.0 release and publish Fleet support as 1.9.1. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Reject Fleet extension types other than microsoft.flux before sending an ARM request. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
microsoft-github-policy-service
Bot
requested a review
from Yong Zhang (yonzhan)
September 28, 2026 19:36
Copilot started reviewing on behalf of
Britania Rodriguez Reyes (britaniar)
September 28, 2026 19:36
View session
Apply the microsoft.flux guard to every extension-type operation that accepts Fleet context. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Collaborator
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
Preserve upstream 1.9.2 and publish Fleet extension validation as 1.9.3. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Return an explicit two-item tuple so Python 3.14 pylint can verify all identity unpacking sites. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Normalize validation inputs, guard Fleet updates, and preserve delete as a cleanup path for unsupported resources. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Arvind Thirumurugan (Arvindthiru)
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fleet extension operations currently rely on the service to reject unsupported extension types. Since Fleet presently supports only
microsoft.flux, fail fast in the CLI before sending ARM requests when another extension type is supplied.Changes
microsoft.fluxas the supported Fleet extension type constant.az k8s-extension createaz k8s-extension updateusing the existing resource's extension typeaz k8s-extension extension-types list-versions-by-locationaz k8s-extension extension-types show-by-clusteraz k8s-extension extension-types list-versions-by-clusteraz k8s-extension extension-types show-version-by-clusterInvalidArgumentValueErrorbefore invoking a mutating or discovery ARM request for unsupported types.k8s-extensionto1.9.3and updates the changelog.Example
Tests
azdev test test_fleet_support --series— 11 tests and 4 subtests passedpython -m pytest src/k8s-extension/azext_k8s_extension/tests/latest/test_chaos_studio.py -q— 30 tests and 24 subtests passedazdev linter k8s-extension— passedazdev style k8s-extension— pylint and flake8 passedgit diff --check— passed