Repository navigation
feat(designer): add Alberta time zone options - #9676
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5d4ecf58-e3c6-4cf2-abc3-7d75b3b8dade
🤖 AI PR Validation ReportPR Review ResultsThank you for your submission! Here's detailed feedback on your PR title and body compliance:✅ PR Title
✅ Commit Type
✅ Risk Level
✅ What & Why
✅ Impact of Change
✅ Test Plan
✅ Contributors
✅ Screenshots/Videos
Summary Table
The PR title and body pass review. The selected risk level is appropriate and matches the code diff and risk label. Powered by: Logic App (fallback) | Last updated: Wed, 28 Oct 2026 20:46:28 GMT |
📊 Coverage Check🎉 All changed files have adequate test coverage! |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5d4ecf58-e3c6-4cf2-abc3-7d75b3b8dade
There was a problem hiding this comment.
🔵 Needs a closer look
Deployed-host support for the persisted 'Alberta Standard Time' ID remains unverified, requiring runtime-owner confirmation or live recurrence and Convert time zone validation before exposing it to users.
No open issues 🎉
What changed in this PR
Adds Alberta Standard Time to the designer’s recurrence and Convert time zone pickers, labeled (UTC-06:00) Mountain Time (Alberta). Runtime support remains host-dependent and unverified; existing workflow values are not migrated.
Changes:
- Adds Alberta to recurrence and both Convert time zone fields while preserving existing options and defaults.
- Adds the recurrence label to the localization catalog.
- Adds tests for option availability and recurrence selection, serialization, and reopening.
| File | Description |
|---|---|
Localize/lang/strings.json |
Adds the localizable Alberta label. |
libs/logic-apps-shared/src/utils/src/lib/helpers/recurrence.ts |
Adds Alberta to recurrence time zone options. |
libs/logic-apps-shared/src/utils/src/lib/helpers/__test__/recurrence.spec.ts |
Tests Alberta availability and preservation of existing options and defaults. |
libs/logic-apps-shared/src/designer-client-services/lib/base/manifests/datetime.ts |
Adds Alberta to the shared Convert time zone options. |
libs/designer-ui/src/lib/recurrence/__test__/recurrence.spec.tsx |
Tests time zone selection, serialization, and reopening. |
Review effort: Balanced
Commit Type
Risk Level
What & Why
Add
Alberta Standard Timeto the recurrence time zone picker and to both time zone fields of the Convert time zone action. The display label(UTC-06:00) Mountain Time (Alberta)matches Microsoft’s Outlook guidance and distinguishes Alberta’s year-round UTC-06:00 from Mountain Time (US & Canada), which observes daylight saving time. Workflows store the Windows IDAlberta Standard Time, not the display label. The change follows existing localization and manifest patterns.This change only exposes the ID in the designer. Availability in deployed runtimes depends on host time zone data and has not been verified. Existing workflow values are not migrated.
Impact of Change
Test Plan
Unit tests added/updated
E2E tests added/updated
Manual testing completed
Tested in: Local Vitest, TypeScript checks, and standalone designer; no live workflow execution or Azure Portal validation.
cd libs/logic-apps-shared && pnpm exec vitest run src/utils/src/lib/helpers/__test__/recurrence.spec.ts --coverage.enabled --coverage.include=src/utils/src/lib/helpers/recurrence.ts --coverage.reporter=text --maxWorkers=1 --no-file-parallelism— passed (6 tests; 100% line coverage for the recurrence helper).cd libs/designer-ui && pnpm exec vitest run src/lib/recurrence/__test__/recurrence.spec.tsx --coverage.enabled=false --maxWorkers=1 --no-file-parallelism— passed (7 tests), including select, serialize and reopen.pnpm exec tsc --noEmit -p libs/logic-apps-shared/tsconfig.json— passed.pnpm exec tsc --noEmit -p libs/designer-ui/tsconfig.json— passed.pnpm exec biome check libs/logic-apps-shared/src/utils/src/lib/helpers/recurrence.ts libs/logic-apps-shared/src/designer-client-services/lib/base/manifests/datetime.ts libs/logic-apps-shared/src/utils/src/lib/helpers/__test__/recurrence.spec.ts libs/designer-ui/src/lib/recurrence/__test__/recurrence.spec.tsx— passed.Contributors
@krmitta_microsoft
Screenshots/Videos
Standalone designer — recurrence time zone:
Standalone designer — Convert time zone source and destination: