Skip to content

feat(designer): add Alberta time zone options - #9676

Merged
Krrish Mittal (takyyon) merged 2 commits into
mainfrom
krmitta-microsoft-alberta-time-zone-designer
Oct 28, 2026
Merged

Krrish Mittal (takyyon) merged 2 commits into
mainfrom
krmitta-microsoft-alberta-time-zone-designer

Conversation

@takyyon

@takyyon Krrish Mittal (takyyon) commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

Commit Type

  • feature - New functionality
  • fix - Bug fix
  • refactor - Code restructuring without behavior change
  • perf - Performance improvement
  • docs - Documentation update
  • test - Test-related changes
  • chore - Maintenance/tooling

Risk Level

  • Low - Minor changes, limited scope
  • Medium - Moderate changes, some user impact
  • High - Major changes, significant user/system impact

What & Why

Add Alberta Standard Time to the recurrence time zone picker and to both time zone fields of the Convert time zone action. The display label (UTC-06:00) Mountain Time (Alberta) matches Microsoft’s Outlook guidance and distinguishes Alberta’s year-round UTC-06:00 from Mountain Time (US & Canada), which observes daylight saving time. Workflows store the Windows ID Alberta Standard Time, not the display label. The change follows existing localization and manifest patterns.

This change only exposes the ID in the designer. Availability in deployed runtimes depends on host time zone data and has not been verified. Existing workflow values are not migrated.

Impact of Change

  • Users: Can select Alberta in recurrence and Convert time zone fields.
  • Developers: No API changes; existing time zone options and defaults are preserved.
  • System: No dependency or runtime changes.

Test Plan

  • Unit tests added/updated

  • E2E tests added/updated

  • Manual testing completed

  • Tested in: Local Vitest, TypeScript checks, and standalone designer; no live workflow execution or Azure Portal validation.

    • cd libs/logic-apps-shared && pnpm exec vitest run src/utils/src/lib/helpers/__test__/recurrence.spec.ts --coverage.enabled --coverage.include=src/utils/src/lib/helpers/recurrence.ts --coverage.reporter=text --maxWorkers=1 --no-file-parallelism — passed (6 tests; 100% line coverage for the recurrence helper).
    • cd libs/designer-ui && pnpm exec vitest run src/lib/recurrence/__test__/recurrence.spec.tsx --coverage.enabled=false --maxWorkers=1 --no-file-parallelism — passed (7 tests), including select, serialize and reopen.
    • pnpm exec tsc --noEmit -p libs/logic-apps-shared/tsconfig.json — passed.
    • pnpm exec tsc --noEmit -p libs/designer-ui/tsconfig.json — passed.
    • pnpm exec biome check libs/logic-apps-shared/src/utils/src/lib/helpers/recurrence.ts libs/logic-apps-shared/src/designer-client-services/lib/base/manifests/datetime.ts libs/logic-apps-shared/src/utils/src/lib/helpers/__test__/recurrence.spec.ts libs/designer-ui/src/lib/recurrence/__test__/recurrence.spec.tsx — passed.
    • Standalone designer: selected Alberta in the recurrence picker and the source and destination time zone fields — passed.

Contributors

@krmitta_microsoft

Screenshots/Videos

Standalone designer — recurrence time zone:

Recurrence settings showing Alberta selected

Standalone designer — Convert time zone source and destination:

Convert time zone settings showing Alberta selected for source and destination

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 5d4ecf58-e3c6-4cf2-abc3-7d75b3b8dade
@takyyon Krrish Mittal (takyyon) added the risk:medium Medium risk change with potential impact label Oct 28, 2026
@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

✅ PR Title

  • Current: feat(designer): add Alberta time zone options
  • Issue: No issue found. The title clearly identifies the affected area and the user-facing change.
  • Recommendation: No change required.

✅ Commit Type

  • Properly selected (feature).
  • Only one commit type is selected, and it accurately reflects the addition of a new time zone option.

✅ Risk Level

  • The selected Medium risk level matches the risk:medium label and is appropriate for a designer-facing option that affects recurrence and Convert time zone fields. The advised risk is medium, so no risk-level update is required.

✅ What & Why

  • Current: Clearly explains what is being added, why the Alberta-specific label is needed, how the Windows ID is stored, and the runtime-data limitation.
  • Issue: No issue found.
  • Recommendation: No change required.

✅ Impact of Change

  • The impact section identifies the affected users and confirms that there are no API, dependency, or runtime changes.
  • Recommendation:
    • Users: The stated impact is accurate: Alberta becomes selectable in recurrence and Convert time zone fields.
    • Developers: The statement that there are no API changes and existing defaults are preserved is appropriate.
    • System: The stated absence of dependency and runtime changes is consistent with the diff.

✅ Test Plan

  • Unit tests are checked and are present in the diff. The tests cover Alberta time zone availability, preservation of existing options, recurrence serialization, and reopening a saved selection.
  • Manual testing is also checked with clear commands, scenarios, and limitations. The test plan passes; E2E tests are not required because unit tests are present.

✅ Contributors

  • A contributor is credited (@krmitta_microsoft).
  • No change required. Consider adding PM or designer contributors if they provided requirements or UX guidance.

✅ Screenshots/Videos

  • Screenshots are included for the visual designer changes and cover both recurrence and Convert time zone scenarios.
  • No change required.

Summary Table

Section Status Recommendation
Title ✅ No change required
Commit Type ✅ feature is correctly selected
Risk Level ✅ Medium risk and risk:medium label agree
What & Why ✅ No change required
Impact of Change ✅ Impact is adequately described
Test Plan ✅ Unit and manual testing are documented
Contributors ✅ Contributor is credited; additional credits are optional
Screenshots/Videos ✅ Appropriate screenshots are included

The PR title and body pass review. The selected risk level is appropriate and matches the code diff and risk label.


Powered by: Logic App (fallback) | Last updated: Wed, 28 Oct 2026 20:46:28 GMT

@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

📊 Coverage Check

🎉 All changed files have adequate test coverage!

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 5d4ecf58-e3c6-4cf2-abc3-7d75b3b8dade
@takyyon
Krrish Mittal (takyyon) marked this pull request as ready for review October 28, 2026 20:44
Copilot AI balanced review requested due to automatic review settings October 28, 2026 20:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Deployed-host support for the persisted 'Alberta Standard Time' ID remains unverified, requiring runtime-owner confirmation or live recurrence and Convert time zone validation before exposing it to users.

No open issues 🎉

What changed in this PR

Adds Alberta Standard Time to the designer’s recurrence and Convert time zone pickers, labeled (UTC-06:00) Mountain Time (Alberta). Runtime support remains host-dependent and unverified; existing workflow values are not migrated.

Changes:

  • Adds Alberta to recurrence and both Convert time zone fields while preserving existing options and defaults.
  • Adds the recurrence label to the localization catalog.
  • Adds tests for option availability and recurrence selection, serialization, and reopening.
File Description
Localize/​lang/​strings.json Adds the localizable Alberta label.
libs/​logic-apps-shared/​src/​utils/​src/​lib/​helpers/​recurrence.ts Adds Alberta to recurrence time zone options.
libs/​logic-apps-shared/​src/​utils/​src/​lib/​helpers/​__test__/​recurrence.spec.ts Tests Alberta availability and preservation of existing options and defaults.
libs/​logic-apps-shared/​src/​designer-client-services/​lib/​base/​manifests/​datetime.ts Adds Alberta to the shared Convert time zone options.
libs/​designer-ui/​src/​lib/​recurrence/​__test__/​recurrence.spec.tsx Tests time zone selection, serialization, and reopening.

Review effort: Balanced

@takyyon
Krrish Mittal (takyyon) merged commit 3593d92 into main Oct 28, 2026
51 checks passed
@takyyon
Krrish Mittal (takyyon) deleted the krmitta-microsoft-alberta-time-zone-designer branch October 28, 2026 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-validated risk:medium Medium risk change with potential impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants