Repository navigation
fix(vscode): restore .NET 8 custom-code creation - #9672
Merged
Brian Lam (lambrianmsft) merged 1 commit intoOct 27, 2026
Merged
Brian Lam (lambrianmsft) merged 1 commit into
Brian Lam (lambrianmsft) merged 1 commit into
Conversation
Revert 0add835 for hotfix/v5.1013. Restore the .NET 8 picker and lifecycle coverage while keeping .NET 10 hidden and preserving subsequent hotfix changes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
🤖 AI PR Validation ReportPR Review ResultsThank you for your submission! Here's detailed feedback on your PR title and body compliance: ✅ PR Title
✅ Commit Type
✅ Risk Level
✅ What & Why
✅ Impact of Change
✅ Test Plan
✅ Contributors
✅ Screenshots/Videos
Summary Table
This revert PR passes review. Thank you for providing clear context and validation details.Powered by: Logic App (fallback) | Last updated: Tue, 27 Oct 2026 18:07:52 GMT |
Andrew Eldridge (andrew-eldridge)
approved these changes
Oct 27, 2026
Brian Lam (lambrianmsft)
merged commit Oct 27, 2026
894545f
into
Azure:hotfix/v5.1013
41 of 42 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Type
Risk Level
What & Why
Revert #9631 (
0add835f2b7704608757a2f9f475e4733eda3f26) onhotfix/v5.1013to restore .NET 8 custom-code workspace creation and hide .NET 10 from the framework picker.Reverses the associated picker, fixture, E2E, documentation, and CI changes. Retains framework-specific runtime settings and hidden .NET 10 backend support from #9611. Subsequent Functions-extension dependency removal, extension-pack changes, and dependency-integrity optimizations remain intact.
Impact of Change
Test Plan
From repository root:
pnpm --dir apps/vs-code-react exec vitest run src/app/createWorkspace/steps/__test__/dotNetFrameworkStep.test.tsx --coverage=false- passed, 17 tests.pnpm --dir apps/vs-code-designer exec vitest run CreateLogicAppProject.test.ts CreateLogicAppWorkspaceIntegration.test.ts functionProjectFiles.test.ts localSettings.test.ts --coverage=false- passed, 133 tests across five files.pnpm run build:extension- passed, all four build tasks.$files = @(git diff --cached --name-only -- '*.ts' '*.tsx'); npx biome check --write $files- passed for all 10 changed TypeScript files; no fixes required. Commit hooks also passed extraction, ESLint, and Biome.git diff --check upstream/hotfix/v5.1013..HEAD- passed.From
apps/vs-code-designer:npx tsup --config tsup.e2e.test.config.ts- passed.pnpm exec mocha out/test/customCodeDotNetVersionShared.test.js- passed, eight tests.node out/test/run-e2e.jswithE2E_MODE=customcodedotnetonly,CUSTOMCODE_DOTNET_E2E_VERSIONS=net8,net10, andCUSTOMCODE_DOTNET_BINARY_PATHset to the system dotnet executable - blocked during VS Code 1.108.0 bootstrap after three retries:Invalid file descriptor to ICU data received. No UI assertions executed; CI must supply UI lifecycle evidence.Contributors
Brian Lam (@lambrianmsft)
Screenshots/Videos
Not captured: local VS Code E2E startup failed before the framework picker could open. Restored unit tests assert .NET 8 is available, .NET 10 is hidden, and .NET Framework remains Windows-only.