Secure MISP API key handling - #14904
Open
idoshabi07 wants to merge 1 commit into
Open
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ccff4d4a-3094-4de9-a5c0-d00c63d96a37
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the Sentinel-to-MISP Logic App ARM template to handle the MISP API key as a secure value and reduce secret exposure in run history.
Changes:
- Changes the
MISP-Keyparameter to a secure string type. - Removes the plaintext
MISPKeyworkflow variable and references the secure parameter directly in HTTPAuthorizationheaders. - Adds
runtimeConfiguration.secureDatato mask action inputs/outputs for authenticated HTTP actions.
Suppressed comments (1)
Playbooks/2S-Sentinel2MISP/MISP-Orchestrator/azuredeploy.json:1
- Using a secure value as a workflow definition parameter
defaultValuecan cause the secret to be persisted in the workflow definition payload at deploy time (and potentially retrievable by users with workflow read access). Prefer defining the workflow parameter asSecureStringwithout adefaultValue, and pass the secret via the workflow resource’s parameters/value mechanism (or a Key Vault reference where supported) so the secret is stored/handled as a secret rather than embedded into the definition.
{
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+355
to
361
| "secureData": { | ||
| "properties": [ | ||
| "inputs", | ||
| "outputs" | ||
| ] | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Uses secure-string parameters, removes the plaintext MISP key variable, references the secure parameter directly, and masks authenticated action data.
AI scan items
Validation
ARM template JSON parsing passed.