Secure MCAS API token handling - #14902
Open
idoshabi07 wants to merge 1 commit into
Open
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ccff4d4a-3094-4de9-a5c0-d00c63d96a37
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the MCAS playbook ARM template to handle the MCAS API token as a secret and reduce exposure in Logic App run history.
Changes:
- Changes the ARM
MCASAPITokenparameter type to a secure type and removes the plaintext-derived ARM variable. - Introduces a Logic App workflow parameter for the token and uses it when constructing the
Authorizationheader. - Adds
runtimeConfiguration.secureDatato mask HTTP action inputs/outputs.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| "MCASAPIToken": { | ||
| "defaultValue": "yourMCAS-API-Token", | ||
| "type": "String" | ||
| "type": "securestring" |
Comment on lines
+85
to
+88
| }, | ||
| "MCASAPIToken": { | ||
| "defaultValue": "[parameters('MCASAPIToken')]", | ||
| "type": "SecureString" |
Contributor
|
Hi idoshabi07, can we proceed to merge this PR. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the MCAS token into a secure workflow parameter, removes its plaintext ARM variable, and masks the authenticated HTTP action data.
AI scan items
Validation
ARM template JSON parsing passed.