Secure client secret handling in Affected Key Credentials playbook - #14896
Open
idoshabi07 wants to merge 1 commit into
Open
Secure client secret handling in Affected Key Credentials playbook#14896idoshabi07 wants to merge 1 commit into
idoshabi07 wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ccff4d4a-3094-4de9-a5c0-d00c63d96a37
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Hardens secret handling in the “Affected Key Credentials” playbook by converting the client secret to secure string types, removing the plaintext Logic App variable, and masking HTTP action run history to avoid leaking authenticated request details.
Changes:
- Convert ARM
ClientSecretparameter tosecurestringand workflow parameter toSecureString - Remove
InitializeVariableaction that stored the client secret as a plaintext variable - Mask action run history by securing inputs/outputs on the authenticated HTTP call
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
141
to
144
| "ClientSecret": { | ||
| "defaultValue": "[parameters('ClientSecret')]", | ||
| "type": "string" | ||
| "type": "SecureString" | ||
| }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes the deployment and workflow client-secret parameters to secure strings, removes the plaintext Logic App variable, and masks the authenticated request inputs and outputs.
AI scan items
Validation
ARM template JSON parsing passed.