Repository navigation
feat: rework table controls - #804
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the table popup's three command rows with row and column selectors, icon-only actions for the selected scope, and a separate Delete table button. Switching scopes preserves the original row and column targets and keeps keyboard focus in the popup. Slim rail grips show the accent color on hover and selection.
The named-folder E2E scenario explicitly selects the source window before closing its dialog after opening a second window, preventing driver focus recovery from routing dialog commands to the new window.
Related Issue
Closes #775
Verification
pnpm exec vitest run src/features/editor/components/editor-context-popup.test.tsx src/features/editor/plugins/contextPopup.test.ts src/features/editor/plugins/tableControls.test.ts --maxWorkers=2— verifies scope switching, range preservation, keyboard reachability and focus return, protected commands, and grip selection alongside the existing popup behavior.pnpm check:frontend— passes formatting, TypeScript, lint, production build, and frontend tests with coverage enforcement.pnpm exec tsc -p e2e/desktop/tsconfig.json --noEmit— validates the updated desktop scenarios' types. Targeted Oxfmt and Oxlint checks also pass for the named-folder scenario.CI run 39214238376 — frontend, backend, and desktop E2E checks pass. Desktop coverage includes named-folder window switching, table scope switching, unchanged table geometry, and spacing before Delete table.
Not verified: a manual desktop pass across all appearances and accent colors. Desktop E2E execution was performed in CI under the repository workflow.