Repository navigation
feat: redesign non-table editor context popups - #803
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make non-table editor context popups compact: icon rows share the available width, sparse rows use short labels, and separators distinguish command groups. Full accessible names and existing command and focus behavior remain intact.
Related Issue
Closes #774
Verification
pnpm test:frontend src/features/editor/components/editor-context-popup.test.tsxchecks labels, command dispatch, keyboard navigation, focus handling, and unchanged table controls.pnpm check:frontendpassed formatting, type checking, lint, the production build, and coverage checks.CI passed frontend checks, backend checks, and desktop E2E, including the updated block-selection layout assertions. Desktop E2E was not run locally.
Notes
Table popups retain their existing presentation. Their redesign belongs to #775.