Repository navigation
feat: choose a new callout's dialect from Insert menus - #797
Merged
Merged
Conversation
Azganoth
force-pushed
the
feature/callout-dialect-choice
branch
2 times, most recently
from
October 18, 2026 18:07
52320f7 to
c97c516
Compare
Azganoth
force-pushed
the
feature/callout-dialect-choice
branch
from
October 18, 2026 19:05
c97c516 to
e8f23df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Insert > Calloutin the menu bar and context popup now offers every supported dialect. The inferred dialect's types stay first, followed by submenus for the other dialects. A choice authors the new callout in that dialect and participates in inference for later insertions. Existing callouts still change type only within their own dialect, and the command palette keeps its inferred-dialect picker.Escape also suppresses a queued pointer-release popup opening, so a dismissed context popup stays closed until a new pointer gesture.
Related Issue
Closes #793
Verification
pnpm exec vitest run src/features/editor/plugins/contextPopup.test.ts src/features/editor/plugins/blockSelectionKeyboard.test.ts src/features/editor/components/editor-context-popup.test.tsxverifies dismissal before a queued pointer release, reopening on a new gesture, selection behavior, and menu interaction. The new dismissal regression fails without the fix.pnpm check:frontendverifies explicit insertion, dialect inference, Markdown round trips, Undo, keyboard menu selection, icons, and focus restoration, alongside the full frontend checks.pnpm exec tsc -p e2e/desktop/tsconfig.json --noEmitvalidates the desktop scenarios.