Skip to content

feat: choose a new callout's dialect from Insert menus - #797

Merged
Azganoth merged 4 commits into
mainfrom
feature/callout-dialect-choice
Oct 18, 2026
Merged

Azganoth merged 4 commits into
mainfrom
feature/callout-dialect-choice

Conversation

@Azganoth

@Azganoth Azganoth commented Oct 18, 2026 •

Copy link
Copy Markdown
Owner

Summary

Insert > Callout in the menu bar and context popup now offers every supported dialect. The inferred dialect's types stay first, followed by submenus for the other dialects. A choice authors the new callout in that dialect and participates in inference for later insertions. Existing callouts still change type only within their own dialect, and the command palette keeps its inferred-dialect picker.

Escape also suppresses a queued pointer-release popup opening, so a dismissed context popup stays closed until a new pointer gesture.

Related Issue

Closes #793

Verification

  • pnpm exec vitest run src/features/editor/plugins/contextPopup.test.ts src/features/editor/plugins/blockSelectionKeyboard.test.ts src/features/editor/components/editor-context-popup.test.tsx verifies dismissal before a queued pointer release, reopening on a new gesture, selection behavior, and menu interaction. The new dismissal regression fails without the fix.
  • pnpm check:frontend verifies explicit insertion, dialect inference, Markdown round trips, Undo, keyboard menu selection, icons, and focus restoration, alongside the full frontend checks.
  • pnpm exec tsc -p e2e/desktop/tsconfig.json --noEmit validates the desktop scenarios.
  • Windows CI passes frontend checks, backend checks and the Rust dependency audit, and the full desktop E2E suite, including the dialect menus and clean teardown.

@Azganoth Azganoth added the Feature New feature or request label Oct 18, 2026
@Azganoth Azganoth self-assigned this Oct 18, 2026
@github-project-automation github-project-automation Bot moved this to Backlog in Leafdown Oct 18, 2026
@Azganoth
Azganoth force-pushed the feature/callout-dialect-choice branch 2 times, most recently from 52320f7 to c97c516 Compare October 18, 2026 18:07
@Azganoth
Azganoth force-pushed the feature/callout-dialect-choice branch from c97c516 to e8f23df Compare October 18, 2026 19:05
@Azganoth
Azganoth merged commit 3126d8b into main Oct 18, 2026
3 checks passed
@Azganoth
Azganoth deleted the feature/callout-dialect-choice branch October 18, 2026 19:37
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Leafdown Oct 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Choose a new callout's dialect from Insert > Callout

1 participant