gitkraken: register gitkraken:// and gk:// URL handlers#310
Conversation
|
The bug is real. Our I don't want to switch the source to the The tarball and the deb ship the same Electron payload. The tarball already contains the launcher ( To get those files, the PR adds We can fix the bug on the current tarball:
Can you rework the PR this way? Thanks for finding the root cause. |
The hand-written GitKraken.desktop carried no scheme MimeType, so the gitkraken:// and gk:// URL handlers never registered and OAuth callback links broke. Fix this on the existing tarball instead of switching the source to the .deb (which only adds these few text files but would cost a /usr/share->/opt relocation and CI rework). - adopt upstream's launcher contents from the deb in GitKraken.desktop (kept under that name so existing favorites/pins stay valid), and add the gitkraken-url-handler and gk-cli-url-handler entries, which register the two schemes and open them via /usr/bin/gitkraken --uri=%U - drop the deb launcher's MimeType=text/plain, which wrongly associated GitKraken with all plaintext files (Azd325#260); the launcher carries no MimeType, so the two --uri handlers own the schemes - symlink /usr/bin/gitkraken to the tarball's resources/bin/gitkraken.sh instead of shipping our own wrapper; drop gitkraken.sh - chmod 4755 chrome-sandbox so Electron's SUID sandbox works (cp drops it) - bump pkgrel to 2 so existing 12.2.1 users get the fix
ff47a32 to
2811038
Compare
|
Sorry for the force push action. ;) |
|
One change before I merge: set One thing to double-check, not a blocker: |
|
|
|
Forgot the .SRCINFO.... |
The hand-written GitKraken.desktop carried no scheme MimeType, so the
gitkraken:// and gk:// URL handlers never registered and OAuth callback
links broke. Fix this on the existing tarball instead of switching the
source to the .deb (which only adds these few text files but would cost a
/usr/share->/opt relocation and CI rework).
(kept under that name so existing favorites/pins stay valid), and add the
gitkraken-url-handler and gk-cli-url-handler entries, which register the
two schemes and open them via /usr/bin/gitkraken --uri=%U
GitKraken with all plaintext files (Desktop file incorrectly associates GitKraken with plaintext files. #260); the launcher carries no
MimeType, so the two --uri handlers own the schemes
instead of shipping our own wrapper; drop gitkraken.sh