Skip to content

Translating AxOS Website#11

Open
Axuentados wants to merge 1 commit into
AxOS-project:mainfrom
Axuentados:main
Open

Translating AxOS Website#11
Axuentados wants to merge 1 commit into
AxOS-project:mainfrom
Axuentados:main

Conversation

@Axuentados
Copy link
Copy Markdown

This new website have been reestructured to support more languages.
changes:
Added Spanish Language
Added Spanish translations
Created english and Spanish Folders.
Blogs next and previous has been translated and the text is now fixed, it shows actual words instead of blog.next or blog.previous.
Now it is "Next / Previos" for English, and "Siguiente / Anterior" for Spanish.
Nav elements have been reworked in order to get the URLs working correctly.
Desing hasn't changed.
Hero title line heigh has been increased on the Spanish version for better experience.

Added translations
Copy link
Copy Markdown
Member

@LeVraiArdox LeVraiArdox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of inconsistencies, please fix them.

Also, pull your local repo, there are ancient snippets in your codebase.

Comment thread public/admin/config.yml
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull the project before publishing a PR

Comment thread astro.config.mjs
Comment thread src/components/blog/pagination.astro
Comment thread src/components/blog/pagination.astro
Comment thread src/components/blog/pagination.astro
Comment thread src/content/blog/new-life-phase.md
Comment thread src/i18n/ui.ts
Comment thread src/pages/docs.astro
Comment thread src/pages/en/rss.xml.js
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should never be moved

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rss.xml.js is available on both english and spanish folders.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even so, it would break every RSS flows, everyone that is subscribed would lose their config

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any suggestion?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just keep the rss file as it was

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or just, don't translate blogs

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand. You made a function to translate strings, but still remake every pages ?

@LeVraiArdox
Copy link
Copy Markdown
Member

Just FYI here is the behavior you should implement

  • Don't rewrite the pages. There should be a dropdown on the navbar where you can select the language. The translation function will set the text on the go and on the same page, without the need to go back to the home page every times.
  • The selected language should be remembered using the local browser cache.

@Axuentados
Copy link
Copy Markdown
Author

maybe I can use the preferred language method on astro, to match the website language with the browser. that might take some time, becuase, if im not wrong, it needs dynamic routes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants