You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Capture optional X-Correlation-Id into ExecutionContext at ASP.NET Core and ASP.NET-integrated Functions boundaries, validate supplied tokens, and echo the effective value on responses.
Propagate correlation through outgoing HTTP requests, newly created events and Service Bus receive processing, preserving explicit overrides, clearing and persisted absence.
Add dynamic logging scopes and the custom correlation.id activity attribute without changing trace identity or baggage; omit correlation on batch publishing spans.
Keep current-request correlation authoritative during idempotency replay while honoring explicit header configuration.
Enable appropriate middleware ordering and logging scopes in host templates and samples; update documentation and the v4.4.0 changelog.
Propagate optional correlation across HTTP, execution contexts, events and Service Bus processing. Add dynamic logging scopes and tracing enrichment, preserve current correlation during idempotency replay, and enable host defaults in templates and samples.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Eric Sibly <eric.sibly@avanade.com>
Adds optional workflow correlation across CoreEx HTTP, Functions and messaging boundaries, connecting related operations without changing trace identity or baggage.
Changes:
Adds validated correlation capture, response echo, outgoing HTTP propagation and event defaults, while preserving explicit overrides and stored absence.
Adds logging scopes and tracing attributes, plus current-request correlation handling during idempotency replay.
Updates templates, samples and documentation, and adds correlation regression tests. Real Functions runtime execution and template/sample validation remain deferred as described in the PR.
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
Native subscribers still invoke CloudEvent detection when correlation is disabled, allowing malformed content types to throw before native deserialization and error classification.
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
Explicitly configured structured receives can incorrectly restore the broker correlation ID over the authoritative envelope value on the completed receive span; scope ownership needs correction and regression coverage.
No open issues 🎉
1 previously missed issue
In code that hasn't changed since last review
Use configured CloudEvent correlation ownership for structured receives
With ContentMode = ContentMode.Structured, a valid envelope without ce_specversion and with application/json or no content type can decode successfully while IsCloudEvent() returns false. This creates an outer broker-correlation scope, so disposing the inner envelope scope restores the broker's correlation.id instead of retaining the authoritative envelope value, including absence, on the completed receive span. Choose ownership solely from UsesCloudEventCorrelation, and add a regression asserting the final activity tag for an explicitly configured structured receive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
X-Correlation-IdintoExecutionContextat ASP.NET Core and ASP.NET-integrated Functions boundaries, validate supplied tokens, and echo the effective value on responses.correlation.idactivity attribute without changing trace identity or baggage; omit correlation on batch publishing spans.Verification