Skip to content

fix(recipe): accept capture=video and websocket for browser-actions #2557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chubes4 merged 1 commit into from
Oct 2, 2026
Merged

fix(recipe): accept capture=video and websocket for browser-actions #2557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/runtime-core/src/command-registry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ const snapshotScopingAcceptedArgs: CommandDefinition["acceptedArgs"] = [
{ name: "snapshot-post-types", description: "Comma-separated post types used to scope posts and postmeta table exports.", format: "string" },
]

const browserActionCaptureValues = ["steps", "actions", "console", "errors", "html", "network", "screenshot", "dom-snapshot"] as const
export const browserActionCaptureValues = ["steps", "actions", "console", "errors", "html", "network", "websocket", "screenshot", "dom-snapshot", "video"] as const
const browserScenarioCaptureValues = ["steps", "actions", "console", "errors", "html", "network", "performance", "memory", "screenshot", "dom-snapshot"] as const
const browserActionEnvironmentAcceptedArgs: CommandDefinition["acceptedArgs"] = [
{ name: "route-host", description: "Preview host alias routed to the local Playground preview.", repeatable: true, format: "hostname" },
Expand Down
13 changes: 13 additions & 0 deletions tests/recipe-validation-descriptors.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,4 +117,17 @@ await withTempDir("wp-codebox-recipe-browser-payload-files-", async (recipeDirec
}
})

await withTempDir("wp-codebox-recipe-validation-capture-", async (recipeDirectory) => {
// Every capture the browser-actions runner accepts must also pass recipe
// validation, or recipe-driven runs (e.g. video recordings) are rejected
// before they start.
const runnerCaptures = ["steps", "console", "errors", "html", "network", "websocket", "screenshot", "dom-snapshot", "video"]
const recipe: WorkspaceRecipe = {
schema: "wp-codebox/workspace-recipe/v1",
workflow: { steps: [{ command: "wordpress.browser-actions", args: ["url=/", `capture=${runnerCaptures.join(",")}`] }] },
}
const issues = await validateWorkspaceRecipeSemantics(recipe, join(recipeDirectory, "recipe.json"))
assert.deepEqual(issues.filter(({ code }) => code === "invalid-capture"), [])
})

console.log("recipe validation descriptors ok")
Loading