Skip to content

Omnibar: Keep the wp-logo and site name icon working with the SVG admin bar icons of WordPress 7.2 - #53835

Merged
fushar merged 1 commit into
trunkfrom
fix/wpcom-admin-bar-remove-house-icon
Oct 20, 2026
Merged

fushar merged 1 commit into
trunkfrom
fix/wpcom-admin-bar-remove-house-icon

Conversation

@fushar

@fushar fushar commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Fixes DOTCOM-18946

Proposed changes

WordPress 7.2 replaces the Dashicons in the admin bar with inline SVG icons (wordpress-develop#12270). This prepares the WordPress.com admin bar CSS so it works on both 7.1 and 7.2:

  • Keep the custom SVG for the wp-logo node, and tweak the padding so 7.1 behavior does not break.
    • This can be removed when all users are on 7.2.
  • Revert the forced house icon for the site-name node. Now frontend will show the odometer icon (Dashicons / SVG) as per Core behavior.

Related product discussion/links

Does this pull request change what data or activity we track or use?

No.

Testing instructions

Verify the admin bar of Simple and Atomic sites still look the same after applying this PR.

@fushar fushar changed the title Omnibar: Keep the WordPress.com logo and site name icon working with the SVG admin bar icons of WordPress 7.2 Omnibar: Keep the wp-logo and site name icon working with the SVG admin bar icons of WordPress 7.2 Oct 20, 2026
@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions Bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Oct 20, 2026
@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (WordPress.com Site Helper), and enable the fix/wpcom-admin-bar-remove-house-icon branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack-mu-wpcom-plugin fix/wpcom-admin-bar-remove-house-icon

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@fushar
fushar marked this pull request as ready for review October 20, 2026 08:38
@fushar fushar removed [Status] In Progress [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Oct 20, 2026
@fushar fushar self-assigned this Oct 20, 2026
@fushar fushar added the [Status] Needs Review This PR is ready for review. label Oct 20, 2026
@jp-launch-control

jp-launch-control Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

@fushar
fushar merged commit dceacc8 into trunk Oct 20, 2026
88 of 90 checks passed
@fushar
fushar deleted the fix/wpcom-admin-bar-remove-house-icon branch October 20, 2026 10:25
@github-actions github-actions Bot removed the [Status] Needs Review This PR is ready for review. label Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant