Collapse leftover fractional tracks on auto-height grids - #1400
Merged
Conversation
Auto-height captured grids still author 1fr row tracks. After WordPress projection those tracks absorb leftover height from a stretched parent or a hidden complementary responsive variant, opening empty space between content rows. Rewrite those tracks to min-content when the matched source box has no definite height floor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1frrow tracks. After WordPress projection those tracks absorb leftover height from a stretched parent, or from a hidden complementary responsive variant that leaves an explicit track empty, opening a blank region between content rows.min-contentwhen every matched source box has no definite height floor (height:auto/min-height:0/display:none). Definite floors such asmin-height:100vhkeep their fractional tracks. Column tracks are unchanged.Closes #1387.
Independent of the semantic ownership work in #868 and nested shell extraction in #1367.
Verification
php tests/unit/responsive-footer-geometry.phpphp tests/unit/responsive-canvas-geometry.phpphp tests/unit/auto-fit-grid-carrier.phpphp tests/unit/responsive-document-variants.phpcomposer --working-dir=php-transformer test(canonical contracts, unit suite, 289 parity fixtures, packaging)AI Assistance
OpenAI gpt-5.6-sol via OpenCode general coding subagent identified the retained empty footer geometry as leftover
1frrow tracks on auto-height grids and hidden complementary responsive variants, implemented the author-stylesheet collapse, added the generic unit fixture, and ran the PHP transformer suite.