Repository navigation
Use the shared deploy tasks from deployer-recipes - #115
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #114. Part of AustinMastLab/Biospex#519 (shared recipe: AustinMastLab/deployer-recipes#3).
Changes
deploy.php: loadsrecipe/ci-artifacts.phpfrom deployer-recipes, which now providesdeploy:ci-artifacts,deploy:verify-structureandsupervisor:reload.deploy/custom.php: the site's own copies of those three tasks are removed. A comment points to the recipe.composer.json:austinmastlab/deployer-recipes^1.2.0-rc1, locked tov1.2.0-rc1, the release candidate from Add shared CI artifact, structure check and Supervisor reload tasks deployer-recipes#3. The constraint also matches the final v1.2.0, socomposer.jsonwon't need to change again; a latercomposer updatemoves the lock to it.supervisor_groupsis['da'].supervisor:reloadused to runsupervisorctl updatewith no group, which applies every pending Supervisor change on the shared server. It now runssupervisorctl update 'da'only, so this site's deploy can't restart another site's programs.Outside GitHub Actions,
deploy:ci-artifactsstill fails the deploy, as this site's copy did.Tested
vendor/bin/pest --compact: 49 passed, 2 skipped.dep tree deployfinds all three tasks.dep config developmentshowsci_artifact_repositoryAustinMastLab/DigitizationAcademy,ci_artifact_namedigitizationacademy, andsupervisor_groups['da'].To verify on development
Run the workflow on
development. In the log:deploy:ci-artifactsdownloadsdigitizationacademy-<sha>.supervisor:reloadrunssudo supervisorctl update 'da'.deploy:verify-structurepasses.Afterwards dev.digitizationacademy.org loads, and
da:da-horizon_00isRUNNING.