Repository navigation
Call alert:publish after Composer dumps the autoloader - #113
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #112.
composer.json'spost-autoload-dumpscript still ranphp artisan sweetalert:publish, which Sweet Alert 8 renamed toalert:publish. Everycomposer installthat runs scripts now fails withCommand "sweetalert:publish" is not defined. That includes local installs and the deploy'sdeploy:vendorsstep.CI didn't catch it because its
composer installruns with--no-scripts.Change
post-autoload-dumprunsphp artisan alert:publish --assets --force --ansi, which publishespublic/vendor/sweetalert/sweet-alert.js, the file the v8 alert view loads.Tested
composer validatepasses.composer installandcomposer dump-autoloadsucceed and publish the asset.To verify on development
The deploy's
deploy:vendorsstep succeeds.