fix: OTA banner on Feed, weekly-rotation share links, rename leftover art - #14597
Merged
dylanjeffers merged 3 commits intoSep 14, 2026
Merged
Conversation
The banner lives in MobileRootHeader, shared by every root tab, but in practice it only ever appeared on Trending. Feed is the initial tab, so its banner mounts while the CodePush root HOC's own sync is already downloading the bundle; the banner's CodePush.sync call returns SYNC_IN_PROGRESS at once and its four early polls (0-4s) finish long before the download does. A tab mounted later (Trending) found the pending package on mount and showed it. Poll for a pending package every 2s for up to 3 minutes after mount and on foreground, stopping as soon as one is found, so the tab that was open during the download shows the banner too. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…issing datafile A shared /explore/weekly-rotation/:handle link redirected first-time visitors to Explore. When the Optimizely datafile tag fails or is slow on a cold cache (index.html's onError installs an empty datafile), every flag falls back to its hard-coded default, and weekly_rotation defaulted to false, so WeeklyRotationPage navigated away. Reproduced in a fresh browser profile; the same link rendered on the second load. The flag has been live at 100% since 2026-09-13, so make the fallback true (and drop the now-redundant development override). Optimizely still wins when it loads, so the remote flag remains the kill switch. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The bundled artwork survived the rename: the shared page, the explore/feed tiles, and the native screen all showed a tile reading DISCOVER WEEKLY. Same black-tile-with-white-text style, new name, on web and mobile. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
dylanjeffers
deleted the
fix/weekly-rotation-share-default-and-ota-banner
branch
September 14, 2026 16:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three follow-ups to the Weekly Rotation launch.
1. Mobile OTA update banner shows on Feed, not just Trending. The banner lives in
MobileRootHeader, which every root tab uses, but in practice it only appeared on Trending. Feed is the initial tab, so its banner mounts while the CodePush root HOC's own sync is already downloading; the banner'sCodePush.syncreturnsSYNC_IN_PROGRESSimmediately and its four early polls (0–4s) end before the download does. Trending, mounted later, found the pending package on mount. Now it polls every 2s for up to 3 minutes after mount/foreground and stops once a pending package appears.2. Shared
/explore/weekly-rotation/:handlelinks no longer bounce first-time visitors to Explore. Reproduced in a fresh browser: first load landed on/explore, second load rendered the page. When the Optimizely datafile tag fails or is slow (index.html'sonErrorinstalls an empty datafile), every flag falls back to its hard-coded default, andweekly_rotationdefaulted tofalse, soWeeklyRotationPagenavigated away. The flag is live at 100%, so the fallback is nowtrue; Optimizely still wins when it loads, so the remote flag remains the kill switch. Ad blockers that block the datafile host hit the same path.3. Cover art still said "Discover Weekly". Web and mobile bundled asset regenerated in the same style with the new name.
Verified
/v1/users/:id/weekly-rotationreturns 30 tracks; SSR meta carriesog:title/og:image;og.audius.co/weekly-rotation/RACreturns the collage PNG.tsc --noEmit -p packages/mobileclean; eslint clean on the banner file.Deploy notes
🤖 Generated with Claude Code