feat(chat): Priority / General inbox split - #14593
Merged
Merged
Conversation
Adds a "missing middle" between muting a conversation and blocking a sender: users can file each chat into a Priority or General inbox tab, and future messages from that sender route there automatically. - SDK: `chats.setCategory` (RPC `chat.set_category`), `chats.getUnreadCountByCategory`, `ChatCategory` enum, `category` on `UserChat`. - Common store: `setChatCategory` with optimistic move + rollback, per-category unread counts (server baseline + optimistic overlay that tracks reads, new messages and moves), per-tab chat list selectors and per-tab unread-dot selectors. The nav dot's fallback scan no longer stops at the first blast row, so a General unread always lights it. - Web: Priority (default) / General pill tabs in the inbox header with independent purple dots, hover options on each list row, and "Move to Priority / General" in the conversation header menu. - Mobile: same tabs and dots on the chat list screen, swipe-left on a row to reveal Priority / General, long-press for the actions drawer, and the same options in the in-conversation drawer. Uncategorized chats surface in the Priority tab (and count towards its dot) so new conversations are never buried without an explicit action. Tabs backfill older pages until they have enough rows, since chats are paginated by recency across categories. Requires the comms server change in AudiusProject/api (migration 0240, `chat.set_category`, `category` on chat rows, `/comms/chats/unread_by_category`). Older nodes still work: the client falls back to the loaded chats for the tab dots when the endpoint is unavailable. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 6390ae3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
4 tasks
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
4 tasks
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
dylanjeffers
added a commit
to AudiusProject/api
that referenced
this pull request
Sep 13, 2026
## Summary
Backend for the **Priority / General inbox split** in the clients. Users
can file each direct-message chat into a Priority or General inbox; the
choice is private to that user and persists so future messages route to
the right tab. A chat with no preference row is uncategorized.
## Changes
- **Migration `0240_user_conversation_preferences.sql`**:
`user_conversation_preferences (user_id, chat_id, category CHECK IN
('priority','general'), updated_at)`, PK `(user_id, chat_id)`.
Idempotent, wrapped in a transaction.
- **RPC `chat.set_category`** `{ chat_id, category: "priority" |
"general" | null }`: validator checks chat membership and the enum;
apply upserts with the RPC timestamp guard (same idiom as
`chat_permissions`), and `null` deletes the row. New `ChatCategory` enum
and `Category` param in `schema.go`.
- **`GET /comms/chats`** and **`GET /comms/chats/:chatId`** now return
`"category"` per chat (`null` for uncategorized and for blast
pseudo-chats). Both queries LEFT JOIN the new table; the `members`
subquery was re-aliased to avoid ambiguity.
- **`GET /comms/chats/unread_by_category`**: `{ priority, general,
uncategorized }` counts of chats with `unread_count > 0`, mirroring
`/comms/chats/unread`'s filter. All three keys are always present.
- `sql/01_schema.sql` / `sql/03_migration_tracker.sql` re-dumped via
`make test-schema`. This also picks up drift from 0238/0239 (which were
never re-dumped) and a pg_dump header version bump from the local image.
`clear_user_records` only exists in the frozen schema dump, so it does
not yet delete from the new table; that needs a separate function
migration if wanted.
## Companion PR
Client side (SDK, store, web and mobile tab UI):
AudiusProject/apps#14593. Deploy this first;
older clients ignore the new field, and the new client falls back
gracefully if the endpoint is missing.
Notifications (pedalboard, DM pushes silenced for chats filed as
General; fails open until the api migration lands):
AudiusProject/pedalboard#93
## Test plan
- [x] `go build ./...`, `go vet` clean, `gofmt` clean on changed files
- [x] `go test ./api/comms/...` (new `TestChatSetCategory`: validator
accept/reject, apply, timestamp guards, clear)
- [x] `go test ./api/...` (new `TestPostMutateChatSetCategory` round
trip through `/comms/mutate` asserting `category` on both GET endpoints
and per-user isolation; new `TestGetUnreadCountByCategory`)
- [ ] Stage: run migration, set a category from the client, confirm
`category` and `unread_by_category` responses
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Users are being message-blasted by artists they follow but don't want to block. This adds the "missing middle" between mute-per-conversation and block: a Priority / General inbox split.
Categorizing is lightweight
Changes
chats.setCategory(RPCchat.set_category),chats.getUnreadCountByCategory,ChatCategoryenum,categoryonUserChat.setChatCategorywith optimistic move and rollback on failure; per-category unread counts (server baseline plus an optimistic overlay that tracks reads, new messages and moves); per-tab chat list and unread-dot selectors; success/failure toasts; two analytics events. Fixed the nav dot's fallback scan, which stopped at the first blast row and could hide a later unread.InboxTabsin the inbox header (fits the existing 112px header),useChatCategoryMenuItemsshared by the list row and the conversation header, per-tab filtering with backfill inChatList.InboxTabs,ChatCategorySwipeActions, swipe/long-press onChatListItem, per-tab filtering with backfill inChatListScreen, new rows inChatActionsDrawer.Because chats are paginated by recency across categories, a tab backfills older pages until it has at least 10 rows or nothing is left.
Companion PR
Backend (migration
0240_user_conversation_preferences,chat.set_category,categoryon chat rows,GET /comms/chats/unread_by_category): AudiusProject/api#1037. Deploy the backend first for accurate tab dots; older clients ignore the new field, and this client falls back to loaded chats for the dots if the endpoint is missing.Not included / follow-ups
Notifications (pedalboard, DM pushes silenced for chats filed as General; fails open until the api migration lands): AudiusProject/pedalboard#93
Test plan
tscclean for sdk, common, web, mobile🤖 Generated with Claude Code