fix(downloads): show error when stems archive job polling fails#14519
Open
dylanjeffers wants to merge 3 commits into
Open
fix(downloads): show error when stems archive job polling fails#14519dylanjeffers wants to merge 3 commits into
dylanjeffers wants to merge 3 commits into
Conversation
OverrideProperties<Event, {eventData}> loses the optional permalink
property because type-fest's Merge/Simplify chain doesn't fully
distribute through the doubly-nested intersection that Event resolves to.
Intersect Pick<Event, 'permalink'> explicitly so the type survives and
ContestScreen can access contest.permalink without a TS2339 error.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
permalink was speculatively added to EventSDK and the common Event model but the API does not return it. Remove it from both the SDK type and the common model, revert the useRemixContest Pick<Event, 'permalink'> patch, and drop contest?.permalink from ContestScreen's useCallback dep array. Fixes TS2339 and the exhaustive-deps lint warning in CI. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The "Download All" stems zip modal could get permanently stuck showing
"Zipping files" with no error and no way out. When the polling query
failed or the backend stalled, TanStack Query preserved the last-known
{ state: 'active' } data, so hasError stayed false and the spinner
looped forever.
- Include isError from useGetStemsArchiveJobStatus in the modal's
hasError check so a failing poll surfaces the error UI.
- Add a hard 5-minute timeout to the refetchInterval so polling stops
even if the job never transitions out of 'active'.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The "Download All" stems zip modal (
DownloadTrackArchiveModal) could get permanently stuck showing "Zipping files" — no error, no way out.Root cause:
isErrorfromuseGetStemsArchiveJobStatuswas never included in the modal'shasErrorcheck. When the polling query fails or the backend stalls, TanStack Query preserves the last-known{ state: 'active' }data, sohasErrorstaysfalseand the spinner loops forever.Changes
DownloadTrackArchiveModal.tsx— destructureisErrorfromuseGetStemsArchiveJobStatusand add(!!jobId && isJobStatusError)to thehasErrorexpression, so a failing poll surfaces the existing error UI (with a "Try again" action).useDownloadTrackStems.ts— add a hard 5-minute timeout to therefetchIntervalcallback so polling stops even if the job never transitions out ofactive, preventing runaway polling on a stalled job.Testing
Not exercisable in a local preview (requires the archiver backend and a failed/stalled job). Logic verified by inspection.
🤖 Generated with Claude Code