Fail builds on all Pester failures - #53
Merged
Merged
Conversation
Count setup and discovery failures in build gates so Pester cannot report a failed run while the build exits successfully. Co-authored-by: Jakub Jareš <me@jakubjares.com>
This was referenced Sep 10, 2026
lipkau
added a commit
to AtlassianPS/JiraPS
that referenced
this pull request
Sep 11, 2026
## Summary - report failed tests, blocks, and containers separately in the parallel runner - use their combined count for success, NUnit suite status, and process exit - record block and container failures as NUnit errors without inflating failed test counts ## Context This applies the failure gate from AtlassianPS/ConfluencePS#256, contributed by @nohwnd. ## Validation - `Invoke-Build -Task Lint, Build, Test` - explicit `Invoke-Build -Task Test` exit code: 0 - generated results: 4,624 checks, 0 failures, 0 errors, 69 skipped - container-only negative fixture: exit code 1 with one failed container ## Release intent Test infrastructure only. No package release. ## Related changes - AtlassianPS/ConfluencePS#256 - AtlassianPS/AtlassianPS.Configuration#53 - AtlassianPS/AtlassianPS.Standards#65 - AtlassianPS/JiraAgilePS#55 - #716 Co-authored-by: Jakub Jareš <me@jakubjares.com>
lipkau
added a commit
to AtlassianPS/JiraAgilePS
that referenced
this pull request
Sep 11, 2026
## Summary - fail integration tests when Pester reports failed blocks or containers - add a build-script regression check for all three Pester 5 counts ## Context This applies the failure gate from AtlassianPS/ConfluencePS#256, contributed by @nohwnd. ## Validation `Invoke-Build -Task Build, Test` 603 passed. ## Release intent Build infrastructure only. No package release. ## Related changes - AtlassianPS/ConfluencePS#256 - AtlassianPS/AtlassianPS.Configuration#53 - AtlassianPS/AtlassianPS.Standards#65 - #55 - AtlassianPS/JiraPS#716 Co-authored-by: Jakub Jareš <me@jakubjares.com>
lipkau
added a commit
to AtlassianPS/AtlassianPS.Standards
that referenced
this pull request
Sep 11, 2026
## Summary - count failed Pester tests, blocks, and containers in lint and module-test gates - preserve the Pester 4 `ContainersFailedCount` compatibility fallback - cover test, block-only, container-only, and legacy container failures ## Context This applies the failure gate from AtlassianPS/ConfluencePS#256, contributed by @nohwnd. ## Validation `Invoke-Build -Task Lint, Build, Test` The test suite passed with 95 tests passed and 35 not run. Lint and PSScriptAnalyzer also passed. ## Release intent Patch release so downstream build scripts can consume the corrected gates. ## Related changes - AtlassianPS/ConfluencePS#256 - AtlassianPS/AtlassianPS.Configuration#53 - #65 - AtlassianPS/JiraAgilePS#55 - AtlassianPS/JiraPS#716 Co-authored-by: Jakub Jareš <me@jakubjares.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
This applies the failure gate from AtlassianPS/ConfluencePS#256, contributed by @nohwnd.
Validation
Invoke-Build -Task Lint, Build, Test945 passed, 19 skipped.
Release intent
Build infrastructure only. No package release.
Related changes