Conversation
Contributor
There was a problem hiding this comment.
Hey - I've reviewed your changes and they look great!
Sourcery assessment
Needs a human reviewer. Clearing the selector writes an empty persona value into the configuration, so existing selections can be lost and reverting the code would not restore them. The affected configuration is bounded and can be repaired by selecting a persona again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When a plugin schema uses
select_persona, selecting a persona leaves no way to return to the empty value. Users therefore cannot clear an explicit override even though the schema documents that an empty persona falls back to the configured persona source.Fixes #9407
Changes
clearablesupport toBaseFolderItemSelector.select_personafields throughConfigItemRenderer.Testing
cd dashboard && npx pnpm@10 run typecheck.git diff --check; the remote branch tree was verified against the local commit tree before opening this PR.Summary by Sourcery
Enable users to clear selected personas from generic persona configuration fields.
New Features:
Bug Fixes:
Enhancements: