Add missing definitions for index.d.ts#120
Merged
Merged
Conversation
nerdalytics
added a commit
to nerdalytics/tinywhale
that referenced
this pull request
Apr 20, 2026
The stable binaryen@129.0.0 runtime expects i64.const(bigint) but ships an index.d.ts still declaring the old (low, high) signature. Switching to nightly 129.0.0-nightly.20260419 picks up the corrected types from upstream PR AssemblyScript/binaryen.js#120 and lets the i64Const wrapper go away. The same nightly carries a separate syntax error in index.d.ts on the i64.atomic.load8_u signature (missing closing paren), which tsc cannot parse. Applied via a one-line pnpm patch. Reported upstream: AssemblyScript/binaryen.js#125. Temporary: remove both the nightly pin and the patch once a stable release carrying PR #120 and the load8_u fix is published.
3 tasks
nerdalytics
added a commit
to nerdalytics/tinywhale
that referenced
this pull request
Apr 20, 2026
* chore(deps): update all direct dependencies to latest Direct deps: - @adonisjs/ace: 13.4.0 -> 14.1.0 - @biomejs/biome: 2.3.12 -> 2.4.12 - @types/node: 25.0.10 -> 25.6.0 - binaryen: 125.0.0 -> 129.0.0 - fast-check: 4.5.3 -> 4.7.0 - ohm-js: 17.3.0 -> 17.5.0 - typescript: 5.9.3 -> 6.0.3 Tooling: - node: 24.13.0 -> 24.15.0 (latest LTS) - pnpm: 10.28.0 -> 10.33.0 Breaking-change fixes: - tsconfig: drop deprecated baseUrl (TS6 would error); add types: ["node"] so Node globals like performance and @types/node ambient modules remain visible under stricter TS6 default resolution. - codegen: binaryen 129 replaced i64.const(low, high) with i64.const(bigint); added i64Const() wrapper that also works around the bundled .d.ts still declaring the old signature. combine32BitPartsToBigInt() helper added to reverse the existing split storage in Inst.arg0/arg1. Side effects: - picomatch is now 2.3.2 via pnpm update -r, closing the two open Dependabot alerts (high + medium) on trunk. - biome 2.4.12 applied formatter/organizeImports auto-fixes in two files (declarations.ts, compile.property.test.ts). Verification: mise run ci is green (857 tests passing). * chore(deps): pin binaryen to nightly with fixed i64.const types The stable binaryen@129.0.0 runtime expects i64.const(bigint) but ships an index.d.ts still declaring the old (low, high) signature. Switching to nightly 129.0.0-nightly.20260419 picks up the corrected types from upstream PR AssemblyScript/binaryen.js#120 and lets the i64Const wrapper go away. The same nightly carries a separate syntax error in index.d.ts on the i64.atomic.load8_u signature (missing closing paren), which tsc cannot parse. Applied via a one-line pnpm patch. Reported upstream: AssemblyScript/binaryen.js#125. Temporary: remove both the nightly pin and the patch once a stable release carrying PR #120 and the load8_u fix is published.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.