ci: nightly browser suite - #540
Open
opticon454 wants to merge 2 commits into
Open
opticon454 wants to merge 2 commits into
opticon454 wants to merge 2 commits into
Conversation
… tests WIP: the suite still has failures on a clean master that are not fixed here. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…roof - opencode-resize: record WebSocket resize frames as well as POST /resize, seed the needsRefresh test with real PTY output, skip the OpenCode close modal test when opencode is not installed - split-pane: send the marker with useMux:false (plain prompts otherwise go through tmux send-keys, which test mode does not have) and retry past Codeman's own post-create clear Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JrzFKEdBLwVfu6ev2ZscJS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A scheduled (03:17 UTC) and manually runnable GitHub Actions workflow,
Browser suite, that runsnpm run test:browseron a clean ubuntu runner (Node 22, tmux,playwright install --with-deps chromium). It is informational only: it is not a merge gate and never blocks a push or PR. The per-push gate (npm test) is unchanged;ci.ymlonly gains a two-line comment pointing at the new job.Why
config/test-suites.tskeeps the Playwright suite out of the per-push gate, which means a browser-only regression (the Shift+Enter keypress bug was one) can merge green. Running it nightly catches those within a day. It needs no secrets: the tests start their own server and drive a local chromium.Left out on purpose:
test:mobile(per-machine PNG baselines),test:perf(wall-clock), andtest/codex-predictive-echo.test.ts(needs a real, authenticated codex binary).Evidence
I ran it on a fork to see whether it can be green on a clean runner. First run: 119 passed, 5 failed. The failures were stale or environment-dependent tests rather than product bugs, so this PR also fixes them:
test/opencode-resize.test.tsdata.id, butPOST /api/sessionsanswers{ success, data: { session } }.{t:'z'}frames while the socket is up, so the test records those as well asPOST /resize.opencodeis not installed.test/split-pane-terminal.browser.test.ts: plain<text>\rinput goes through tmuxsend-keys, which test mode does not have, so the marker never landed. It is now sent withuseMux:falseand retried past Codeman's own post-createclear.test/perf-browser.test.ts: same session-id envelope fix.Latest fork run (before #534 landed, on 1.34.0): 122 passed, 1 skipped, 1 failed, the one failure being
test/inline-rename.test.ts(rail rename editor clamped), a real product bug that #534 / #526 have since fixed on master. This branch is rebased onto 1.35.0 andinline-rename,opencode-resizeandsplit-pane-terminalpass locally (36 passed, 1 skipped for the OpenCode-not-installed case), so the first nightly run should be green. I have not re-run the whole suite on a runner since the rebase: Actions → Browser suite → Run workflow after merge is the quickest confirmation.Notes
permissions: contents: read.🤖 Generated with Claude Code
https://claude.ai/code/session_01JrzFKEdBLwVfu6ev2ZscJS