fix(rail): keep the inline rename editor unclamped in the detailed tab rail - #534
Open
opticon454 wants to merge 1 commit into
Open
opticon454 wants to merge 1 commit into
opticon454 wants to merge 1 commit into
Conversation
The card-row rule (line-clamp: 3) out-ranked the shared unclamp-while-renaming override. Restate it at the same weight; the test now covers both rail layouts. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Renaming a session in the detailed vertical tab rail (the default rail layout) left the 3-line name clamp on the inline editor, because the card-row rule out-ranked the shared "unclamp while renaming" override.
Cause
.tab-name.tab-name-renamingsets-webkit-line-clamp: unset, but the detailed-rail rulehtml[data-tab-orientation='vertical'][data-tab-rail-detail='rich']:not(.tab-rail-compact) .tab-rail .session-tab .tab-name(which setsline-clamp: 3) carries four more selectors of specificity, so the override never won in the default layout. The existing test,Vertical rail paints typing in an unclamped editor…, caught it, but it lives in the browser suite that the per-push CI gate does not run, so it went unnoticed (I measured it failing on a clean 1.33.3 checkout; the CSS and the test are unchanged in 1.34.0).Fix
Restate the override at the same weight, after the rule it beats. One rule in
styles.css.The test also encoded the wrong expectation for the default layout (it asserted a 2-line clamp after cancelling the rename, but the detailed rail intentionally clamps to 3, as its own comment says). It now runs for both layouts: simple → 2 lines, detailed → 3 lines; each must be unclamped while renaming and restore its own clamp on cancel.
Tests
test/inline-rename.test.ts(real Chromium): now parameterised over both rail layouts. 15 pass (14 existing + the added layout); the detailed-layout case failed before the CSS change.🤖 Generated with Claude Code
https://claude.ai/code/session_01JrzFKEdBLwVfu6ev2ZscJS