Skip to content

Fork patch: Swallow author-code throws in probe seeks - #6

Draft
valeriangalliat wants to merge 1 commit into
mainfrom
patch/probe-seek-swallow
Draft

valeriangalliat wants to merge 1 commit into
mainfrom
patch/probe-seek-swallow

Conversation

@valeriangalliat

Copy link
Copy Markdown
Collaborator

🤖 AI agent: Arcade fork patch. Do not merge.

This draft shows patch/probe-seek-swallow against main, the upstream mirror, so the patch has one page for its diff, its revisions and its reason. Arcade's /hyperframes-update rebases the branch onto main and cherry-picks it onto arcade; this PR is not part of that flow. When a rebuild changes the patch, its git range-diff against the previous sync/<date>/probe-seek-swallow tag is posted as a comment.

Why

Some older saved compositions tween a GSAP className onto SVG elements, which throws in strict mode. The editor's rAF loop keeps going after the throw, but the render plan's probe stopped. The patch swallows author-code throws during probe seeks, so render behaves like the editor. Arcade's generator no longer emits this pattern.

Upstream

Kept local: the throw is an authoring bug, not a HyperFrames one. Carried before as ArcadeHQ/hyperframes#31.

Drop when

No saved composition still tweens className onto SVG.

Arcade

ARC-13425 · ARC-14433

@valeriangalliat
valeriangalliat force-pushed the patch/probe-seek-swallow branch from 061d2ba to 2a81409 Compare October 24, 2026 23:23
@github-actions

github-actions Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Edit accuracy: accurate 271 (base branch 271), smooth 115 of those

The gate passes.
Smoothness is reported in the artifact, not gated. A case fails only if it fails 2 of 3 runs.

Quarantined, measured but not gated (0)

Unstable (2)

  • seqplainkeys-none-px-r0-root-z100: tracking 0.06, pressJump 0, drop 0, reload 0, render 0.03, renderKey -, undo false, teleport true / tracking 0.06, pressJump 0, drop 0, reload 0, render 0.03, renderKey -, undo true, teleport true / tracking 0.06, pressJump 0, drop 0, reload 0, render 0.03, renderKey -, undo true, teleport true
  • seqheldtwice-tlhold-px-r0-nested-z100: tracking 120.29, pressJump 312.3, drop 0.07, reload 0.07, render 0.03, renderKey -, undo true, teleport false / tracking 0.41, pressJump 0.11, drop 0.39, reload 0.39, render 0.02, renderKey -, undo true, teleport true / tracking 0.41, pressJump 0.11, drop 0.39, reload 0.39, render 0.02, renderKey -, undo true, teleport true

Keep-local: old published comps tween GSAP className onto SVG and
throw in strict mode. Editor rAF already continues; plan probe must too.
New emit no longer does this. Do not upstream.
@valeriangalliat
valeriangalliat force-pushed the patch/probe-seek-swallow branch from 2a81409 to cbf2b9b Compare October 25, 2026 02:43

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant