feat: add LIGHTSPEED G305 support#369
Open
watzon wants to merge 2 commits into
Open
Conversation
Greptile SummaryThis PR adds first-class LIGHTSPEED G305 support. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (2): Last reviewed commit: "fix: preserve battery level for unknown ..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0x1000battery support with cached refreshes, live0x2201DPI access, and marketing-name fallback0x1b0xcapture feature existsWhy
OpenLogi previously treated
046d:c53fas an unrecognized HID++ node, so the connected G305 receiver could not surface its paired slot or route feature operations to device index 1. LIGHTSPEED uses Unifying-style HID++ 1.0 receiver registers (0x2Npairing information,0x3Nextended information, and0x4Nnames), while the paired mouse exposes HID++ 2.0 features at its receiver slot.This change models that receiver family explicitly and keeps hardware writes disabled when a stable receiver identity is unavailable.
User impact
The G305 now appears as a named mouse with WPID, battery, pointer, and Buttons panels. DPI reads/writes target the paired slot, and standard middle/back/forward controls remain remappable through the OS input hook. Gaming-only DPI button capture, onboard profiles, persistent hardware mappings, and gaming RGB remain deferred.
Validation
cargo test --workspace --no-fail-fastcargo fmt --all -- --checkgit diff --check046d:c53fD686CB5EG305407490%, discharging0x1000,0x2201,0x8100, and0x8110on slot 13200, write/read back3250, restore3200