Repository navigation
CI: build Docker image and publish to PyPI for release tags - #2688
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heads-up before the next release. Since the CI reorg (#2444),
build-docker.ymlandpypi-upload.ymlonly run for tags starting withv, but releases are tagged without a prefix (4.5.13). 4.5.13 was published by the oldbuild-deploy.yml. As things stand, tagging 4.5.14 would produce neither a Docker image nor a PyPI upload.Changes:
X.Y.Z, optionallyaN/bN/rcN). A small check job confirms the tag points at the commit Python CI tested. For a tag push, Python CI'shead_branchis the tag name.workflow_run, checkout and metadata-action default to the default branch. That means a tag build would usedev's Dockerfile and lock file and be taggeddev. The Docker build now checks out the release tag and takes tags from it (context: git), producingX.Y.Zpluslatestfor final releases. The PyPI job runs the tag's own functional tests.pushCI runs trigger builds, which the PyPI workflow already required.type=match,value=latest,pattern=pattern=…rule. It never matched and only produced a warning;type=pep440already addslatestto final releases.devbuilds are unchanged. Checked with actionlint. This conflicts with #2687 (weekly rebuild); I'm happy to rebase that one on top once this lands.