Skip to content

Fix OTA manifest lambda for ESPHome dev - #99

Closed
bharvey88 wants to merge 1 commit into
mainfrom
ota-url-const-char
Closed

bharvey88 wants to merge 1 commit into
mainfrom
ota-url-const-char

Conversation

@bharvey88

@bharvey88 bharvey88 commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Version: 26.9.29.1

What does this implement/fix?

Fixes the build against ESPHome dev. esphome#19211 changed the http_request update entity's set_source_url() to take a const char * and keep the pointer, so passing a std::string fails with cannot convert 'std::string' to 'const char*'.

apply_ota_source now picks between the two manifest URLs as string literals, which stay valid for the life of the firmware. Current stable still accepts this, since its const std::string & parameter converts from const char *. No change in behavior.

Types of changes

  • Bugfix (fixed change that fixes an issue)
  • New feature (thanks!)
  • Breaking change (repair/feature that breaks existing functionality)
  • Dependency Update - Does not publish
  • Other - Does not publish
  • Website of github readme file update - Does not publish
  • Github workflows - Does not publish

Checklist / Checklijst:

  • The code change has been tested and works locally
  • The code change has not yet been tested

If user-visible functionality or configuration variables are added/modified:

  • Added/updated documentation for the web page

🤖 Generated with Claude Code

Summary by CodeRabbit

Updates

  • Updated the ESPHome firmware version from 26.8.27.1 to 26.9.29.1. Update-source selection and assignment remain unchanged. No other end-user-visible changes are noted in this release.

@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Warning

Review limit reached

Next included review available in 46 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 16227b67-f859-4e4e-b65a-d276c30f67ac

📥 Commits

Reviewing files that changed from the base of the PR and between 920ee1e and b30a956.

📒 Files selected for processing (1)
  • Integrations/ESPHome/Core.yaml

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 5c31138a-58b0-40f0-8f2c-3385698344ef

📥 Commits

Reviewing files that changed from the base of the PR and between 7b5cd4c and 920ee1e.

📒 Files selected for processing (1)
  • Integrations/ESPHome/Core.yaml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The ESPHome configuration updates the firmware version from 26.8.27.1 to 26.9.29.1. The OTA source function stores the selected manifest URL as a const char * and logs it directly. Stable and Beta URL selection remains unchanged.

Changes

ESPHome Core

Layer / File(s) Summary
Firmware version and OTA URL logging
Integrations/ESPHome/Core.yaml
The configured firmware version changes to 26.9.29.1. apply_ota_source stores the selected manifest URL as a const char * and logs it directly. Stable and Beta URL selection remains unchanged.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Suggested reviewers: bunton33

Merge Risk: ⚪ Minimal · up to 920ee

The OTA manifest selection remains unchanged, and the firmware version is consistent with the repository’s configurations and beta workflow. No actionable merge risk is evident.

Architecture Summary

Architecture risk: 🔵 Low · up to 920ee

The change affects 1 system.

Changed systems: Integrations

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — Integrations (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in Integrations/ESPHome/Core.yaml: The configured firmware version changes from 26.8.27.1 to 26.9.29.1.
  • observed — Modified behavior in Integrations/ESPHome/Core.yaml: apply_ota_source now stores the selected manifest URL in a const char * and logs it directly; it previously used a std::string and passed url.c_str() to the logger. The Stable/Beta URL selection is unchanged.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: fixing the OTA manifest lambda for ESPHome development builds.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the version line
The firmware hops to twenty-six nine
A manifest URL, held light
Gets logged without a string in sight
Then carrots crunch beneath the moon

Comment @coderabbitai help to get the list of available commands.

@bharvey88
bharvey88 changed the base branch from beta to main September 29, 2026 22:04
@bharvey88 bharvey88 closed this Oct 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant