Skip to content

Add paths=True support to nbrg/nbrga and extract shared _paths_reduce helper - #25

Merged
jph00 merged 1 commit into
mainfrom
paths
Aug 7, 2026
Merged

Add paths=True support to nbrg/nbrga and extract shared _paths_reduce helper#25
jph00 merged 1 commit into
mainfrom
paths

Conversation

@ncoop57

@ncoop57 ncoop57 commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • nbrg/nbrga now support paths=True to return unique matched notebook paths as PathResults, matching the existing rg API. paths is mutually exclusive with count (asserted at call time).
  • Extracted _paths_reduce from the inline dedup logic in rg() and _rg_post() so both rg and nbrg share one implementation for path reduction, capping, and timeout flags.
  • rg() paths-with-timeout now goes through the unified _rg_post_paths_reduce path instead of a separate code branch, fixing consistent stop_reason reporting.
  • Updated README and skill docs to reflect nbrg's new paths/count parity with rg.

@ncoop57 ncoop57 added the enhancement New feature or request label Aug 7, 2026
@ncoop57
ncoop57 marked this pull request as ready for review August 7, 2026 02:24
@ncoop57
ncoop57 requested a review from jph00 August 7, 2026 02:24
@jph00
jph00 merged commit 1e474ad into main Aug 7, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants