Add timeout_ms to fd, walk, ls, and async path functions - #23
Merged
Conversation
timeout_ms for path walks: fd/fda/walk/ls on the shared stream engine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Path-finding functions (
fd,walk,ls,fda) now accepttimeout_ms, returning partial results withstop_reason=\"timeout\"— matching the existing behavior onrg/rga/nbrg/nbrga.Changes
walk.rs: Refactoredfind/find_cancelableinto a unifiedfind_iterbuilt on the genericStreamIter/spawn_walkengine, eliminating the bespoke channel/worker code.findis now a thincollect()over the iterator.python.rs:walk_py,find_py, andfind_async_pyroute throughcollect_stream_py/stream_asyncwith deadline support, returning(Vec<String>, bool)tuples so Python can setstop_reason.__init__.py: Addedtimeout_msparam towalk,fd, andfda; results wrapped via_mk_resultsto carry the timeout flag.DEV.mdandREADME.mdto documenttimeout_mson all path functions.fd,walk, andfda.fd_iter/fda_iter: Lazy path walks over the samefind_iterengine, yieldingFileEntryrows. Adds theFindIterpyclass and_core.find_iter/find_iter_asyncinpython.rs.