Add for/endfor iteration and scoped variable resolution to fill_tokens - #33
Open
ncoop57 wants to merge 4 commits into
Open
Add for/endfor iteration and scoped variable resolution to fill_tokens#33ncoop57 wants to merge 4 commits into
ncoop57 wants to merge 4 commits into
Conversation
ncoop57
marked this pull request as draft
August 5, 2026 15:31
ncoop57
marked this pull request as ready for review
August 5, 2026 19:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Extends the template engine in
mdhtml.mdwith two capabilities:{% for x in y %}…{% endfor %}(jinja) and list-valued{{#name}}…{{/name}}(mustache) now repeat their span once per item, binding each item to a frame pushed onto a scope stack.ifpushes nothing (names stay lexical),forpushes{bind: item}.Why
These are the core missing pieces for real-world templates that repeat over lists (tables, grant tables, contingency lists) while keeping the byte-identical-preservation guarantee of
fill_tokens.Changes
mdhtml/md.py: rewrites the fill loop to build a node tree, then render viabuild/walk; adds_resolvefor dotted-path scope lookup andstandalonefor whole-line marker removal.mdhtml/jinja.py:_classifynow returns a 4-tuple withbindforforstatements; docstring updated.mdhtml/mustache.py:_classifypasses'.'as the bind so list sections iterate; docstring updated.tests/test_export.py: replaces thefor-unsupported assertion with awhileone; addstest_fill_iteration_and_scopesandtest_jinja_forcovering list iteration, dotted paths, innermost-frame precedence, staged fills, and table contexts.