Skip to content

feat: add MCP configuration review action - #2878

Open
dungdong-aws wants to merge 1 commit into
Amazon-Q-Developer:feature/mcp-security-enchancefrom
dungdong-aws:fix/mcp-consent-dialog-display
Open

dungdong-aws wants to merge 1 commit into
Amazon-Q-Developer:feature/mcp-security-enchancefrom
dungdong-aws:fix/mcp-consent-dialog-display

Conversation

@dungdong-aws

Copy link
Copy Markdown
Contributor

Summary

Adds a View full configuration action to the workspace MCP approval dialog.

Selecting it opens the workspace .amazonq/mcp.json file with editor focus, then displays the approval dialog again. The server is not started and no approval is recorded until the user explicitly chooses Allow for this server.

Behavior

Workspace MCP approval dialog
  → View full configuration
  → Open .amazonq/mcp.json
  → Re-display approval dialog
  → Allow or Deny

This lets users inspect the complete source configuration before making their approval decision while preserving the existing Allow/Deny behavior.

Tests

Adds coverage that verifies:

  • the review action opens the expected workspace configuration URI with focus;
  • the dialog is displayed again after review;
  • a later Deny does not record approval.

Validation

  • Prettier check passed.
  • TypeScript no-emit compile passed for server/aws-lsp-codewhisperer.
  • Normal pre-commit and pre-push hooks passed.
  • The focused unit suite was not run locally; CI will run the repository checks.

@dungdong-aws
dungdong-aws requested a review from a team as a code owner September 16, 2026 23:23
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 88.67925% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...anguage-server/agenticChat/tools/mcp/mcpManager.ts 88.67% 6 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants