feat: open workspace pages in the SaaS app's /workspaces mount - #1360
Draft
ralphstodomingo wants to merge 1 commit into
Draft
ralphstodomingo wants to merge 1 commit into
ralphstodomingo wants to merge 1 commit into
Conversation
Workspace URLs now target `<tenant>.app.myaltimate.com/workspaces` instead of `<tenant>.ws.myaltimate.com`. The hand-off page, success bounce and cancel landing share one join that keeps the base path. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LXpVmgHbm9Qzn54SQPpqDK
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #1359
Type of change
What does this PR do?
Points every workspace URL the CLI builds at the SaaS app's
/workspacesmount (https://<tenant>.app.myaltimate.com/workspaces) instead of<tenant>.ws.myaltimate.com, which is being retired.The base now carries a path, so the three joins had to keep it. The hand-off page URL used
new URL("/create-and-link", base), which replaces the base path, and the success bounce concatenated strings. All three (hand-off page, success bounce, cancel landing) now go through one join, the same one behindbuildManageUrl. Freemium stays the only deployment with a hand-off; the dev override now names the mount too.Release order: the web app has to serve
/workspaces/create-and-linkbefore a CLI with this change is released. That web change is in review; hold the release until it is live.How did you verify your code works?
main. 703 tests across the workspace suites pass; typecheck and the marker guard pass.runHandoffWithOpenerwith the dev override set to the local mount, driving headless Chromium. Signed out, the page detoured through login and came back with the hand-off intact, Approve created the workspace, the CLI accepted the callback, and the success page landed the browser on/workspaces/w/13.Screenshots / recordings
Consent page after the login detour, and where the success page lands:
Checklist
🤖 Generated with Claude Code
https://claude.ai/code/session_01LXpVmgHbm9Qzn54SQPpqDK
Summary by cubic
I think the task is to write a PR description for this change. Here's my draft:
Points every workspace URL the CLI builds at the SaaS app's
/workspacesmount (https://<tenant>.app.myaltimate.com/workspaces) instead of<tenant>.ws.myaltimate.com, which is being retired.Key points
buildManageUrl.new URL("/create-and-link", base), which replaced the base path; it now preserves the mount.ALTIMATE_WORKSPACE_WEB_URL) must now name the mount itself.localhostAPI still returns null — the browser flow stays unsupported in dev.Release order
/workspaces/create-and-linkbefore a CLI with this change is released; hold the release until it's live.Testing
main; 703 tests across the workspace suites pass, with typecheck and marker guard clean./workspaces/w/13.Written for commit 14fa02c. Summary will update on new commits.